Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753165AbdICWNz (ORCPT ); Sun, 3 Sep 2017 18:13:55 -0400 Received: from mail-vk0-f68.google.com ([209.85.213.68]:36576 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbdICWNx (ORCPT ); Sun, 3 Sep 2017 18:13:53 -0400 X-Google-Smtp-Source: ADKCNb77sVBGNmQ0V/m7QJAGKNv28og2OntmTg7Yq/oaCJ7xWOkJnas0UGDJIsBYXIo14fP3nRKo3Wz805+Hgv/Fi4U= MIME-Version: 1.0 In-Reply-To: <20170829195322.GB2304@bhelgaas-glaptop.roam.corp.google.com> References: <1503855651-17409-1-git-send-email-okaya@codeaurora.org> <20170829195322.GB2304@bhelgaas-glaptop.roam.corp.google.com> From: Yinghai Lu Date: Sun, 3 Sep 2017 15:13:51 -0700 X-Google-Sender-Auth: 4qtRmw6BPWBY0zWshZWjgA07-cg Message-ID: Subject: Re: [PATCH V13 1/4] PCI: Don't ignore valid response before CRS timeout To: Bjorn Helgaas Cc: Sinan Kaya , "linux-pci@vger.kernel.org" , timur@codeaurora.org, Alex Williamson , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Bjorn Helgaas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 26 On Tue, Aug 29, 2017 at 12:53 PM, Bjorn Helgaas wrote: > > Applied this series to pci/enumeration for v4.14. You didn't include a > cover letter, but the series includes: > > [V13 1/4] PCI: Don't ignore valid response before CRS timeout > [V13 2/4] PCI: Factor out pci_bus_wait_crs() > [V13 3/4] PCI: Handle CRS ('device not ready') returned by device af > [V13 4/4] PCI: Warn periodically while waiting for device to become > > I made some changes: > > - Renamed pci_bus_crs_visibility_pending() to pci_bus_crs_vendor_id() > because the CRS completion is not "pending". It is not waiting > somewhere for us to do something about it. The CRS completion has > already occurred and is over. All we have now is a magic Vendor ID > value that tells us that it happened. > > - Split addition of pci_bus_crs_vendor_id() to a separate patch, move > it to probe.c, and make it static. the calling of pci_bus_crs_vendor_id() in pci_bus_read_dev_vendor_id() could be removed. pci_bus_wait_crs() have that calling inside. -Yinghai