Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753295AbdIDGwl (ORCPT ); Mon, 4 Sep 2017 02:52:41 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:33521 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdIDGwi (ORCPT ); Mon, 4 Sep 2017 02:52:38 -0400 X-Google-Smtp-Source: ADKCNb5wYRNFk0HmitXWUhXbqlplED4rCocH647d+nCipWMX9B/oBavFLGuYfp/0bN5lBfPlEwVNdA== From: Leo Yan To: "Rafael J. Wysocki" , Daniel Lezcano , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan , Stefan Wahren Subject: [PATCH 2/2] ARM: cpuidle: replace cpuidle_get_driver with cpuidle_get_cpu_driver Date: Mon, 4 Sep 2017 14:52:14 +0800 Message-Id: <1504507934-14218-2-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504507934-14218-1-git-send-email-leo.yan@linaro.org> References: <1504507934-14218-1-git-send-email-leo.yan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 39 commit d50a7d8acd78 ("ARM: cpuidle: Support asymmetric idle definition") supports multiple CPU idle driver so every CPU has its own driver. When the initialization fails, the failure handling releases the resources for every previous CPU; so it needs to retrieve every CPU device and driver handler and unregister them. But the function cpuidle_get_driver() can only return current CPU driver handler but not the iterated CPU driver handler, so it cannot release resource properly. This patch is to replace cpuidle_get_driver() with cpuidle_get_cpu_driver(), every CPU has its own device handler so this function can get back correct driver handler for the CPU according to the CPU device handler. By using this CPU driver handler we can release resource properly. Cc: Daniel Lezcano Cc: Stefan Wahren Signed-off-by: Leo Yan Fixes: d50a7d8acd78 ("ARM: cpuidle: Support asymmetric idle definition") --- drivers/cpuidle/cpuidle-arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c index f419f6a..ef34780 100644 --- a/drivers/cpuidle/cpuidle-arm.c +++ b/drivers/cpuidle/cpuidle-arm.c @@ -161,9 +161,9 @@ static int __init arm_idle_init(void) while (--cpu >= 0) { dev = per_cpu(cpuidle_devices, cpu); + drv = cpuidle_get_cpu_driver(dev); cpuidle_unregister_device(dev); kfree(dev); - drv = cpuidle_get_driver(); cpuidle_unregister_driver(drv); kfree(drv); } -- 2.7.4