Subject: Re: [PATCH 2/8] kbuild: Support for Symbols.list creation
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        mbenes@suse.cz, mmarek@suse.cz, pmladek@suse.com, jikos@suse.cz,
        nstange@suse.de, jroedel@suse.de, matz@suse.de, jpoimboe@redhat.com,
        khlebnikov@yandex-team.ru, jeyu@kernel.org
References: <20170829190140.401-1-jmoreira@suse.de>
 <20170829190140.401-3-jmoreira@suse.de>
 <20170831152439.3qmzrrg4atlj5yve@redhat.com>
From: Joao Moreira <jmoreira@suse.de>
Message-ID: <0a3f8c14-3311-3862-1f37-d0c3e81ac698@suse.de>
Date: Mon, 4 Sep 2017 04:23:29 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170831152439.3qmzrrg4atlj5yve@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 964
Lines: 27


On 08/31/2017 12:24 PM, Joe Lawrence wrote:
> Hi Joao,
> 
Hi Joe and Josh,

Thanks for the quick feedback, I'll be looking forward for your comments 
once you have the change to dig deeper :). I'll apply all typo-fixes, 
add klpclean to the PHONY targets and change the quiet_cmd invocation as 
suggested in v2.

>> For identifying livepatches during the build process, a flag variable
>> LIVEPATCH_$(basetarget).o is considered in scripts/Makefile.build. This
>> way, set this flag for the livepatch sample Makefile in
>> samples/livepatch/Makefile.
> 
> I've never tried building a livepatch out of tree (is that even
> possible?) but does this make it any more/less harder?

Tbh, I never had tried it before, so I just emulated the process and it 
was simple and successful. All it required in addition to what is 
regular, was the introduction of the "LIVEPATCH_($bastarget).o := y" 
into the Makefile. All else was implicitly handled by Kbuild.

Best,
Joao