Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbdIDHoJ (ORCPT ); Mon, 4 Sep 2017 03:44:09 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:34312 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbdIDHoH (ORCPT ); Mon, 4 Sep 2017 03:44:07 -0400 Date: Mon, 4 Sep 2017 09:43:55 +0200 From: Maxime Ripard To: Stefan =?iso-8859-1?Q?Br=FCns?= Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Code Kipper , Andre Przywara Subject: Re: [PATCH 05/10] dmaengine: sun6i: Move number of pchans/vchans/request to device struct Message-ID: <20170904074355.niloziky42aki7bg@flea> References: <20170903224100.17893-1-stefan.bruens@rwth-aachen.de> <20170903224100.17893-6-stefan.bruens@rwth-aachen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hs4nqmfrjcgcpunc" Content-Disposition: inline In-Reply-To: <20170903224100.17893-6-stefan.bruens@rwth-aachen.de> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1771 Lines: 48 --hs4nqmfrjcgcpunc Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 04, 2017 at 12:40:56AM +0200, Stefan Br=FCns wrote: > Preparatory patch: If the same compatible is used for different SoCs which > have a common register layout, but different number of channels, the > channel count can no longer be stored in the config. Store it in the > device structure instead. >=20 > Signed-off-by: Stefan Br=FCns As stated already, we already are going to have a different compatible, and this is not something that will change from one instance to the other. Having code is therefore: A) Making the code more complex B) For no particular reason. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --hs4nqmfrjcgcpunc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZrQQ7AAoJEBx+YmzsjxAg4sIP/juFa5MC/C0tdGXRLFS0/DGD 5XpDuI8Iu6R34p6JU+cd+RYEJSDzKyrOkBqVmgHvhrq99BpJe+aerw+UbLrZrKXj 4kBKaNCtb7wyNe424q4z1ZbtwW/Xkj9aMqcXYbNzJ6wtsltOoK+MU1YuEEy1SziH WTkh4EDiu2W7He66yEtKrdOfcQt+kGwACZ/P/dK5pxNVyMqW3EsA/IjO7JPsxZ3C H9bE2JLAW3srQAnMCPJFUXeYwX4v5YE6niOpDjHaBuEeUuohsS4r+vBhE25kafRX aAoxK+JlJLu1Z/QuHDP6HnuhU6o7H6bt7MfhFsueviPx0harFJv4tyBfaee1hDf9 nWtcRP+QofT+pop+dpWsojTJaCie5ZXyKZOzAER6t1yL2IyQDUSylgKjCz0FkZ40 94yW77BvgoRr9ySr49RFPWbrj3urcPpt3AWH6CqqgxF8PnQkbWnw/S4HTO3tEHn/ ycDFDEdz3v2MZkAKCfCDq3IEGSvLO+ACPrVeUKPzrLH5IYX5KHiPtF6PIhmIyNaW YOABPR0s8Ix4gVhPNgEgLaa9kWhTTFV42TaEg3eCCcrCTMIVAsO/s6YvK7k04miO oFFUtmOyi/2FULdPx3H6Lg41Ee5nVIMMgN+gN28DZZkioMUgXW0fDxbgMU6jN9JM 8nOtcRvbig05x1A4SUEC =Jwhi -----END PGP SIGNATURE----- --hs4nqmfrjcgcpunc--