Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbdIDIDO (ORCPT ); Mon, 4 Sep 2017 04:03:14 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35034 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753270AbdIDIDG (ORCPT ); Mon, 4 Sep 2017 04:03:06 -0400 Date: Mon, 4 Sep 2017 10:02:55 +0200 From: Maxime Ripard To: Philipp Rossak Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1 on Nanopi M1 Plus Message-ID: <20170904080255.3aywcccu4io2fvxi@flea> References: <1504283401-4263-1-git-send-email-embed3d@gmail.com> <1504283401-4263-2-git-send-email-embed3d@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iinwv3hxe3mal5qx" Content-Disposition: inline In-Reply-To: <1504283401-4263-2-git-send-email-embed3d@gmail.com> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2595 Lines: 85 --iinwv3hxe3mal5qx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Philipp, On Fri, Sep 01, 2017 at 06:30:00PM +0200, Philipp Rossak wrote: > From: Philipp Rossak >=20 > The WiFi side of the AP6212 WiFi/BT combo module is connected to > mmc1. There are also GPIOs for enable and interrupts. >=20 > Enable WiFi on this board by enabling mmc1 and adding the power > sequencing clocks and GPIO, as well as the chip's interrupt line. >=20 > Signed-off-by: Philipp Rossak > --- > arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 25 +++++++++++++++++++++= ++++ > 1 file changed, 25 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts b/arch/arm/boo= t/dts/sun8i-h3-nanopi-m1-plus.dts > index 6256f55..7d18c35 100644 > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts > @@ -48,6 +48,13 @@ > =20 > aliases { > serial1 =3D &uart3; > + ethernet1 =3D &sdio_wifi; > + }; > + > + wifi_pwrseq: wifi_pwrseq { > + compatible =3D "mmc-pwrseq-simple"; > + pinctrl-names =3D "default"; > + reset-gpios =3D <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */ > }; > }; > =20 > @@ -65,6 +72,24 @@ > status =3D "okay"; > }; > =20 > +&mmc1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc1_pins_a>; > + vmmc-supply =3D <®_vcc3v3>; I know I told you you weren't needing vqmmc, but Chen-Yu later told me that I was wrong about this. I've added vqmmc back, and applied your patch. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --iinwv3hxe3mal5qx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZrQivAAoJEBx+YmzsjxAg7+AQAJjsEGTGBZM1dbzZLRr+aAO1 8gNj9xupkSXz6KQf7zerAJuH2wHhrJTXZNXpVWewL5hkaZvkQLH3WHzKQxB7yyg3 R+icIW8262qnOs31o38SG5z6M6q7Jt+Nq43x4G4BGHKiTGa4CgBCym+WTmo8VvHI lz91W+ZjxcXLmeYRC9P7h3ulKWYdBx8lwhfHjAl+m6QHQZ38BAOodpC8kMh5vRjC F6zlewL6NgM+nc7fncJwwJxALTROckLN1slzswRhhdec/VqMyJjyZdYY5nC9kPUp 9ex3hihTapVaxRhCRWjOjk1aNumirEzsBjULJcp+jQERP3n9i0F9Uk25RYGhdopN 6mosULQLLdzY2h8qZD/JawE5Vx5sg8LD9OAVYrqPnbYixu48n8D+LBo26RiOBLUH wBqK76FwCYAXIMsuRHEhIljWkl1nGs8FA+dVF6OhPbwLuhVvFScqPHOU7zhL8/6K 4BX8JxxwfU7exbWGmJ7dzkKw7pwf+RCPYUSY/3gvYUqyGYOuEUgjldEqjWyG1bF2 5VhS1bYrmRflcznVjbkTuLDa/fqOELhcgpMS/kF2fL+0nMcZ7fZVnvWoe8nG85ya ukJNIRnVSTsWKyPYm3Bval/e3UdlF6d41qjJEGnxc4QsMurTZ03ylzVR2o9t40ew M01zC7kibeQhs8wHKfV8 =GIle -----END PGP SIGNATURE----- --iinwv3hxe3mal5qx--