Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753406AbdIDIFc (ORCPT ); Mon, 4 Sep 2017 04:05:32 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35146 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbdIDIFb (ORCPT ); Mon, 4 Sep 2017 04:05:31 -0400 Date: Mon, 4 Sep 2017 10:05:19 +0200 From: Maxime Ripard To: Philipp Rossak Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 2/2] ARM: dts: sun8i: h3: Improved Wifi bindings on Bananapi M2 Plus Message-ID: <20170904080519.mec6ypjei7uvo5k7@flea> References: <1504283401-4263-1-git-send-email-embed3d@gmail.com> <1504283401-4263-3-git-send-email-embed3d@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="m2x3r73jxsrlo2md" Content-Disposition: inline In-Reply-To: <1504283401-4263-3-git-send-email-embed3d@gmail.com> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2582 Lines: 85 --m2x3r73jxsrlo2md Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Philipp, On Fri, Sep 01, 2017 at 06:30:01PM +0200, Philipp Rossak wrote: > From: Philipp Rossak >=20 > * vqmmc is in this case not needed > * no need for pincontrol nodes when the pin is set to a GPIO >=20 > Signed-off-by: Philipp Rossak > --- > arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts b/arch/arm/b= oot/dts/sun8i-h3-bananapi-m2-plus.dts > index d756ff8..f7e5d8a 100644 > --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts > +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts > @@ -98,7 +98,6 @@ > wifi_pwrseq: wifi_pwrseq { > compatible =3D "mmc-pwrseq-simple"; > pinctrl-names =3D "default"; > - pinctrl-0 =3D <&wifi_en_bpi_m2p>; > reset-gpios =3D <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */ > }; > }; > @@ -153,7 +152,6 @@ > pinctrl-names =3D "default"; > pinctrl-0 =3D <&mmc1_pins_a>; > vmmc-supply =3D <®_vcc3v3>; > - vqmmc-supply =3D <®_vcc3v3>; So we actually need this one. > mmc-pwrseq =3D <&wifi_pwrseq>; > bus-width =3D <4>; > non-removable; > @@ -200,11 +198,6 @@ > pins =3D "PL3"; > function =3D "gpio_in"; > }; > - > - wifi_en_bpi_m2p: wifi_en_pin { > - pins =3D "PL7"; > - function =3D "gpio_out"; > - }; And there's also other GPIO pins here, I'd prefer if you could tackle them all at once. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --m2x3r73jxsrlo2md Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZrQk/AAoJEBx+YmzsjxAgd/MQAKHPUQMjSfLbgg0XAr/IxHWZ mr4AAg6hPQS54S9/6r2Ypjkx5slSjG+APDixTXIZtCgX3Bw4D8Wrwn/9sOfzgnXL hDD0OTVosH/RKlH6XTKFSapjaRdI43/PRp/f/mPn8U8fUj2fb3wpNT2Y7GWhHcWS qAIKXirZvoskEAlE5H3PN/wflKOgbk2E7EFXqhX69in7djwSS+vvBdEuRa2zKo9S poxOQVLBeOtJlKSTPma41ZR9DfP9sFMkCp0burVye8t8Jvr3rUl2x4Zf0JeUGFXO FzMHUyenBKTDe6hxBhJIgX1by3BiBxZ4iWywpNhpWB16nlYM2CHvZbyO0YyIrTje rpgLFfW0cLII18RlRcJI78jh9WbsQeJh9ix+R+O3jxZ9VJGNhygjUjG7knp0DmXS hoezeTjfGU9UilBF+AokgA0XLFbhOxrDvVPZfWSOnKhWL8t0m6teVgDhPq5oZIAw jd26AVlrwg6bbQ72Ol7S/NfpImWGx2ne+6OB/2Azv2iNHhny8Id8r41stu1JzwCI 0d18tePtftAg5jO269vq3FF8JLZlKx603cVwJNXQSUXmfeHfIc6eCFsw4oFmijP0 ukLeSxii5oM1livpBcXxJwY9TOd8lwu1ZLkDkr+Q9lPRkaGpiVnH1dINLfEoNIMX WSu7yci7ZIGE47ozwnKl =P89y -----END PGP SIGNATURE----- --m2x3r73jxsrlo2md--