Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753409AbdIDIwp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Sep 2017 04:52:45 -0400
Received: from mail.cn.fujitsu.com ([183.91.158.132]:4368 "EHLO
        heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1753318AbdIDIwo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Sep 2017 04:52:44 -0400
X-IronPort-AV: E=Sophos;i="5.41,473,1498492800"; 
   d="scan'208";a="25185674"
Subject: Re: [PATCH v2] kaslr: get ACPI SRAT table to avoid movable memory
To: Baoquan He <bhe@redhat.com>
References: <20170903143123.22031-1-fanc.fnst@cn.fujitsu.com>
 <2895411.GR6mzpbNLk@aspire.rjw.lan> <20170904022619.GB30906@x1>
 <4f2f9d6e-8d6e-e518-bcb6-493d898b7341@cn.fujitsu.com>
 <20170904083914.GD30906@x1>
CC: Chao Fan <fanc.fnst@cn.fujitsu.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
        <linux-acpi@vger.kernel.org>, <hpa@zytor.com>, <tglx@linutronix.de>,
        <mingo@redhat.com>, <keescook@chromium.org>, <arnd@arndb.de>,
        <dyoung@redhat.com>, <dave.jiang@intel.com>, <lv.zheng@intel.com>,
        <indou.takao@jp.fujitsu.com>, <izumi.taku@jp.fujitsu.com>,
        <yasu.isimatu@gmail.com>
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
Message-ID: <81a45045-56c3-af28-758f-f9eaec13d95e@cn.fujitsu.com>
Date: Mon, 4 Sep 2017 16:52:39 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170904083914.GD30906@x1>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.167.226.106]
X-yoursite-MailScanner-ID: 70E894725549.A8B32
X-yoursite-MailScanner: Found to be clean
X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1259
Lines: 57

Hi Baoquan,

At 09/04/2017 04:39 PM, Baoquan He wrote:
> On 09/04/17 at 04:17pm, Dou Liyang wrote:
>> With "movable_node=1024M" option in cmdline, KASLR will can't access
>> the node3 memory.
>
> So you have extended the movable_node option from no value specified to
> adding a limit value, then why don't you go one step further to extend
> it as movable_node=xxx@start. With this, you can eat the cake you have.
>

Haha, extending it as movable_node=xxx@start is my last choice. I
don't want this option to be as complex as memmap is.

> My personal opinion, could that other peopel have better idea. But dig
> into acpi tables to grab the srat table, that is really not a good idea.
>

I agree with you. That is why I send method 2.

> Chao has spent time to know the srat table, maybe he can try to make a
> patch with the "movable_node=xxx@start" handling in kaslr.c, let's see
> what it looks like.
>

OK, go ahead, Chao.

Thanks,
	dou.


> Thanks
> Baoquan
>
>>
>> I am looking for the solution of this. Not find a good way.
>>
>> Sometimes, I will remember that proverb:
>>
>>   You cannot have your cake and eat it too. :-)
>>
>> Thanks,
>> 	dou.
>>> touch ACPI tables with so many lines of code.
>>>
>>> Thanks
>>> Baoquan
>>>
>>>
>>>
>>
>>
>
>
>