Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753424AbdIDKVU (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Sep 2017 06:21:20 -0400
Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:40490 "EHLO
        mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751321AbdIDKVT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Sep 2017 06:21:19 -0400
Authentication-Results: ppops.net;
        spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com
Date: Mon, 4 Sep 2017 11:18:49 +0100
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Lee Jones <lee.jones@linaro.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Daniel Mack <daniel@zonque.org>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        <linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
        <patches@opensource.wolfsonmicro.com>, <alsa-devel@alsa-project.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support
Message-ID: <20170904101849.7uefwhuqz4vtntrp@localhost.localdomain>
References: <20170902195414.3699-1-robert.jarzmik@free.fr>
 <20170902195414.3699-10-robert.jarzmik@free.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20170902195414.3699-10-robert.jarzmik@free.fr>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0
 suspectscore=8 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011
 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709040166
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 750
Lines: 25

On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote:
> Add support for the new ac97 bus model, where devices are automatically
> discovered on AC-Links.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v4:
>  - added #ifdef spotted by Charles
> ---
>  	snd_soc_codec_init_regmap(codec, regmap);
> @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec)
>  	struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec);
>  
>  	snd_soc_codec_exit_regmap(codec);
> -	snd_soc_free_ac97_codec(wm9712->ac97);
> +	if (!wm9712->mfd_pdata)
> +		snd_soc_free_ac97_codec(wm9712->ac97);

This bit is still missing the ifdef it has in the preceeding
patch.

Otherwise looks good to me.

Thanks,
Charles