Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753532AbdIDK5j (ORCPT ); Mon, 4 Sep 2017 06:57:39 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:36673 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411AbdIDK5h (ORCPT ); Mon, 4 Sep 2017 06:57:37 -0400 X-Google-Smtp-Source: ADKCNb5DCgD/TPJtykj5FtCpFu2F2ZsdzquQ7oAafvFoX46zLdzXklEa7LOGhj+EfaMAfV0+fgxy/D9ublc7AU/qJFA= MIME-Version: 1.0 In-Reply-To: <20170904105322.23228-1-colin.king@canonical.com> References: <20170904105322.23228-1-colin.king@canonical.com> From: Baolin Wang Date: Mon, 4 Sep 2017 18:57:36 +0800 Message-ID: Subject: Re: [PATCH][pinctrl-next] pinctrl: sprd: make three local functions static To: Colin King Cc: Linus Walleij , Baolin Wang , linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2753 Lines: 74 Hi, On 4 September 2017 at 18:53, Colin King wrote: > From: Colin Ian King > > The functions sprd_pmx_get_function_count, sprd_pmx_get_function_name > and sprd_pmx_get_function_groups are local to the source and do not > need to be in global scope, so make them static. > > Cleans up sparse warnings: > "symbol 'sprd_pmx_get_function_count' was not declared. Should it be > static?" > "symbol 'sprd_pmx_get_function_name' was not declared. Should it be > static?" > "symbol 'sprd_pmx_get_function_groups' was not declared. Should it be > static?" > > Signed-off-by: Colin Ian King Ah, I missed these functions, thanks for fixing this issue. > --- > drivers/pinctrl/sprd/pinctrl-sprd.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c > index 7e7b9ac7e836..c178b4a6d7f5 100644 > --- a/drivers/pinctrl/sprd/pinctrl-sprd.c > +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c > @@ -353,13 +353,13 @@ static const struct pinctrl_ops sprd_pctrl_ops = { > .dt_free_map = pinctrl_utils_free_map, > }; > > -int sprd_pmx_get_function_count(struct pinctrl_dev *pctldev) > +static int sprd_pmx_get_function_count(struct pinctrl_dev *pctldev) > { > return PIN_FUNC_MAX; > } > > -const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev, > - unsigned int selector) > +static const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev, > + unsigned int selector) > { > switch (selector) { > case PIN_FUNC_1: > @@ -375,10 +375,10 @@ const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev, > } > } > > -int sprd_pmx_get_function_groups(struct pinctrl_dev *pctldev, > - unsigned int selector, > - const char * const **groups, > - unsigned int * const num_groups) > +static int sprd_pmx_get_function_groups(struct pinctrl_dev *pctldev, > + unsigned int selector, > + const char * const **groups, > + unsigned int * const num_groups) > { > struct sprd_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev); > struct sprd_pinctrl_soc_info *info = pctl->info; > -- > 2.14.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Baolin.wang Best Regards