Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753505AbdIDLWS (ORCPT ); Mon, 4 Sep 2017 07:22:18 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:37955 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753410AbdIDLWR (ORCPT ); Mon, 4 Sep 2017 07:22:17 -0400 X-Google-Smtp-Source: ADKCNb6FOvSWxWJPX27o/MnfZI5+1ODMa9mDvFE4n4kCY1JMtAChl+4a9igOXNHJ0v8QFgbtEEIEUQ== From: Michal Hocko To: Andrew Morton Cc: Vlastimil Babka , , LKML , Michal Hocko Subject: [PATCH] mm, sparse: fix typo in online_mem_sections Date: Mon, 4 Sep 2017 13:22:10 +0200 Message-Id: <20170904112210.3401-1-mhocko@kernel.org> X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 32 From: Michal Hocko online_mem_sections accidentally marks online only the first section in the given range. This is a typo which hasn't been noticed because I haven't tested large 2GB blocks previously. All users of pfn_to_online_page would get confused on the the rest of the pfn range in the block. All we need to fix this is to use iterator (pfn) rather than start_pfn. Fixes: 2d070eab2e82 ("mm: consider zone which is not fully populated to have holes") Cc: stable Signed-off-by: Michal Hocko --- mm/sparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/sparse.c b/mm/sparse.c index a9783acf2bb9..83b3bf6461af 100644 --- a/mm/sparse.c +++ b/mm/sparse.c @@ -626,7 +626,7 @@ void online_mem_sections(unsigned long start_pfn, unsigned long end_pfn) unsigned long pfn; for (pfn = start_pfn; pfn < end_pfn; pfn += PAGES_PER_SECTION) { - unsigned long section_nr = pfn_to_section_nr(start_pfn); + unsigned long section_nr = pfn_to_section_nr(pfn); struct mem_section *ms; /* onlining code should never touch invalid ranges */ -- 2.14.1