Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbdIDLkx (ORCPT ); Mon, 4 Sep 2017 07:40:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45324 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753380AbdIDLkw (ORCPT ); Mon, 4 Sep 2017 07:40:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F38B260847 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control To: Andrzej Hajda , Philippe CORNU , Laurent Pinchart , David Airlie , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Yannick Fertre , Benjamin Gaignard , Vincent Abriou , Alexandre Torgue , Maxime Coquelin , Gabriel Fernandez , Ludovic Barre , Fabien Dessenne , Mickael Reulier References: <1501593788-21036-1-git-send-email-philippe.cornu@st.com> <1501593788-21036-4-git-send-email-philippe.cornu@st.com> From: Archit Taneja Message-ID: Date: Mon, 4 Sep 2017 17:10:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2233 Lines: 67 On 09/01/2017 07:15 PM, Andrzej Hajda wrote: > On 01.08.2017 15:23, Philippe CORNU wrote: >> Based on patch "Convert drivers to explicit reset API" from Philipp Zabel >> >> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting >> reset lines") started to transition the reset control request API calls >> to explicitly state whether the driver needs exclusive or shared reset >> control behavior. Convert all drivers requesting exclusive resets to the >> explicit API call so the temporary transition helpers can be removed. >> >> No functional changes. >> >> Cc: Philipp Zabel >> Signed-off-by: Philippe CORNU >> Acked-by: Philipp Zabel >> --- >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +++------- >> 1 file changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> index 781340d..4e1f91e 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> @@ -885,15 +885,11 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge *bridge) >> * Note that the reset was not defined in the initial device tree, so >> * we have to be prepared for it not being found. >> */ >> - apb_rst = devm_reset_control_get(dev, "apb"); >> + apb_rst = devm_reset_control_get_optional_exclusive(dev, "apb"); >> if (IS_ERR(apb_rst)) { >> ret = PTR_ERR(apb_rst); >> - if (ret == -ENOENT) { >> - apb_rst = NULL; >> - } else { >> - dev_err(dev, "Unable to get reset control: %d\n", ret); >> - return ERR_PTR(ret); >> - } >> + dev_err(dev, "Unable to get reset control: %d\n", ret); > > I think in case of deferred probing it shouldn't be dev_err, but this is > rather suggestion. > >> + return ERR_PTR(ret); > > return apb_rst; > > With this fixed: > Reviewed-by: Andrzej Hajda queued to drm-misc-next after incorporating Andrzej's comment. > > -- > Regards > Andrzej > >> } >> >> if (apb_rst) { > > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project