Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753734AbdIDNwn (ORCPT ); Mon, 4 Sep 2017 09:52:43 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:32888 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753557AbdIDNwl (ORCPT ); Mon, 4 Sep 2017 09:52:41 -0400 X-Google-Smtp-Source: ADKCNb7RpvHVrxnX87qNpTErGaU8UDMd4NVCzJvJORzHRs5UA8k6vJpqI1yBSpKAyhZvQQzClk2LEw== Subject: Re: [PATCH v2 2/2] ARM: dts: sun8i: h3: Improved Wifi bindings on Bananapi M2 Plus To: Maxime Ripard Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com References: <1504283401-4263-1-git-send-email-embed3d@gmail.com> <1504283401-4263-3-git-send-email-embed3d@gmail.com> <20170904080519.mec6ypjei7uvo5k7@flea> From: Philipp Rossak Message-ID: Date: Mon, 4 Sep 2017 15:52:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170904080519.mec6ypjei7uvo5k7@flea> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1632 Lines: 59 Hi Maxime Am 04.09.2017 um 10:05 schrieb Maxime Ripard: > Hi Philipp, > > On Fri, Sep 01, 2017 at 06:30:01PM +0200, Philipp Rossak wrote: >> From: Philipp Rossak >> >> * vqmmc is in this case not needed >> * no need for pincontrol nodes when the pin is set to a GPIO >> >> Signed-off-by: Philipp Rossak >> --- >> arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts >> index d756ff8..f7e5d8a 100644 >> --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts >> +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts >> @@ -98,7 +98,6 @@ >> wifi_pwrseq: wifi_pwrseq { >> compatible = "mmc-pwrseq-simple"; >> pinctrl-names = "default"; >> - pinctrl-0 = <&wifi_en_bpi_m2p>; >> reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */ >> }; >> }; >> @@ -153,7 +152,6 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&mmc1_pins_a>; >> vmmc-supply = <®_vcc3v3>; >> - vqmmc-supply = <®_vcc3v3>; > > So we actually need this one. > >> mmc-pwrseq = <&wifi_pwrseq>; >> bus-width = <4>; >> non-removable; >> @@ -200,11 +198,6 @@ >> pins = "PL3"; >> function = "gpio_in"; >> }; >> - >> - wifi_en_bpi_m2p: wifi_en_pin { >> - pins = "PL7"; >> - function = "gpio_out"; >> - }; > > And there's also other GPIO pins here, I'd prefer if you could tackle > them all at once. > > Thanks! > Maxime > Thanks for the feedback! I will fix that with a new single Patch in the next Days. Philipp