Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753780AbdIDN40 (ORCPT ); Mon, 4 Sep 2017 09:56:26 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:58189 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753727AbdIDN4Y (ORCPT ); Mon, 4 Sep 2017 09:56:24 -0400 From: Philippe CORNU To: Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Philipp Zabel , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" CC: Alexandre TORGUE , Fabien DESSENNE , Yannick FERTRE , "Maxime Coquelin" , Mickael REULIER , Vincent ABRIOU , "Gabriel FERNANDEZ" , Ludovic BARRE Subject: Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control Thread-Topic: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control Thread-Index: AQHTIyiNF37F2aLh7k2iLgjg7K4La6KkfXGAgAAlzoA= Date: Mon, 4 Sep 2017 13:56:03 +0000 Message-ID: <6e89bf21-6b4a-d721-e747-f8dab016b58a@st.com> References: <1501593788-21036-1-git-send-email-philippe.cornu@st.com> <1501593788-21036-4-git-send-email-philippe.cornu@st.com> In-Reply-To: Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="utf-8" Content-ID: <8F00F6F57A4DA24691C3C1B3BF395E8E@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-04_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v84DuVt3016977 Content-Length: 2413 Lines: 74 On 09/04/2017 01:40 PM, Archit Taneja wrote: > > > On 09/01/2017 07:15 PM, Andrzej Hajda wrote: >> On 01.08.2017 15:23, Philippe CORNU wrote: >>> Based on patch "Convert drivers to explicit reset API" from Philipp >>> Zabel >>> >>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting >>> reset lines") started to transition the reset control request API calls >>> to explicitly state whether the driver needs exclusive or shared reset >>> control behavior. Convert all drivers requesting exclusive resets to the >>> explicit API call so the temporary transition helpers can be removed. >>> >>> No functional changes. >>> >>> Cc: Philipp Zabel >>> Signed-off-by: Philippe CORNU >>> Acked-by: Philipp Zabel >>> --- >>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +++------- >>> 1 file changed, 3 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >>> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >>> index 781340d..4e1f91e 100644 >>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >>> @@ -885,15 +885,11 @@ static int dw_mipi_dsi_bridge_attach(struct >>> drm_bridge *bridge) >>> * Note that the reset was not defined in the initial device >>> tree, so >>> * we have to be prepared for it not being found. >>> */ >>> - apb_rst = devm_reset_control_get(dev, "apb"); >>> + apb_rst = devm_reset_control_get_optional_exclusive(dev, "apb"); >>> if (IS_ERR(apb_rst)) { >>> ret = PTR_ERR(apb_rst); >>> - if (ret == -ENOENT) { >>> - apb_rst = NULL; >>> - } else { >>> - dev_err(dev, "Unable to get reset control: %d\n", ret); >>> - return ERR_PTR(ret); >>> - } >>> + dev_err(dev, "Unable to get reset control: %d\n", ret); >> >> I think in case of deferred probing it shouldn't be dev_err, but this is >> rather suggestion. >> >>> + return ERR_PTR(ret); >> return apb_rst; >> >> With this fixed: >> Reviewed-by: Andrzej Hajda > > queued to drm-misc-next after incorporating Andrzej's comment. > Dears Archit & Andrzej, A big *THANK YOU* for review/rework/integration, Philippe :-) >> >> -- >> Regards >> Andrzej >> >>> } >>> if (apb_rst) { >> >> >