Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753866AbdIDPBE (ORCPT ); Mon, 4 Sep 2017 11:01:04 -0400 Received: from mail-sn1nam01on0078.outbound.protection.outlook.com ([104.47.32.78]:61505 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753734AbdIDPBB (ORCPT ); Mon, 4 Sep 2017 11:01:01 -0400 Authentication-Results: spf=pass (sender IP is 137.71.25.57) smtp.mailfrom=analog.com; pmeerw.net; dkim=none (message not signed) header.d=none;pmeerw.net; dmarc=bestguesspass action=none header.from=analog.com; From: Dragos Bogdan To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron CC: Hartmut Knaack , Peter Meerwald-Stadler , , , Dragos Bogdan Subject: [PATCH] iio:ad7793: Fix the serial interface reset Date: Mon, 4 Sep 2017 18:00:48 +0300 Message-ID: <20170904150048.12420-1-dragos.bogdan@analog.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:137.71.25.57;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(107886003)(50226002)(77096006)(50466002)(246002)(8676002)(50986999)(8666007)(54906002)(47776003)(305945005)(7636002)(48376002)(356003)(478600001)(53416004)(4326008)(5003940100001)(36756003)(33646002)(626005)(72206003)(5660300001)(6666003)(8936002)(106466001)(1076002)(2906002)(189998001)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR03MB2698;H:nwd2mta4.analog.com;FPR:;SPF:Pass;PTR:nwd2mail11.analog.com;MX:1;A:1;LANG:en; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4092b41a-dd39-4278-3239-08d4f3a5c090 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR03MB2698; X-MS-TrafficTypeDiagnostic: DM5PR03MB2698: X-Forefront-Antispam-Report-Untrusted: X-Microsoft-Exchange-Diagnostics: 1;DM5PR03MB2698;20:1WhbJAVC/6dckK0bYW9k/XO+w9UxYMkbWVMLNyhL2hrPoAtV614jys9knmqeVe1cRrjajAphOQXbQx8Emb5URFJybo88eLTPbPPz0XflXuiCnr80lYyZOESp8J3q4yqZuDos9RG0WtNq3eh2724yQ4W8pwGdZH7t9tEbMwmEe6CRwaUx172gA8b1F3dLiztAw7Y97C3GEJAr5uRJ/l7+vSTdrfS+CEaQ9sgW8jrIw37Etn3Df8Usq2ZEb5LGLoDrcyDhOd7ilDWAWrVSyZelVoOahwfKTg0D98cDIUoAkiqKaYfOjm9z4B1d9ZvOAsitOibPkUJE8QKa2i5fFohNFtaN+upkFoI0gF0/58tTHfHdOUqec7SEF1ww0wAqG2w4XFnkAaHS04OundslR53wbnkgIu7LfKerz1Gq14CEJedRMK+U/JuoHMRVbcBdCPb9+HlbiYzqU2GsVliiA+LOdZ5LFwK2FnztbVzqkvEhAER6XAyfjzJOfD0D5w/bPZW6;4:ADjvMyjXdktI4cR0TIuMErpQUYEr0vbNSNqel1schk8iskZHZCxOcDq2/IZRNobYgjR71xQePnv7pg3HLcTrUksS/bbrnCiOKk39mxDwTb5oogF7m///fH+uXhvJoIzXvn/ivMxHv0MZEgxwt50ZVL0N/a7BjWIMjpKkexTZOlvLncViQxouemX+abmz5/OrxotPm1NeO0z9DnM9GBEk81dPA5kIxSYWUhtWUGxUZRDckJSrHyCms7CvtfjZ0xuYtTyDYtI5kbSyLrDiUcuYhAxEiZ592mLbcfwW8dT840A= X-Exchange-Antispam-Report-Test: UriScan:(232431446821674); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93004095)(100000703101)(100105400095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR03MB2698;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR03MB2698; X-Forefront-PRVS: 0420213CCD X-Microsoft-Exchange-Diagnostics: 1;DM5PR03MB2698;23:YFXXGbqp+bEwLMYxYUIVGnqm6Wdzi58Y7jKZvVfhx0m5x+3O+sITkDOVC4j7phrQ7ANRNyi2687OGlx2Jzxy+c+hO8ioVl1zBlBuIjPfrorg7TFkWa0p76BRg8+m9LVSPbWAU3nUr3iWp47wVT/dZO6AiMSqfOV8ol3Gs3VtftbpdsbQTXeJbWgaKLpYRi1a4fhprTP8z28v/wZI/DLoRZycyAF5D4GBDgg8HnhVIOJaCuUD54pyOK0a9psgR6VPFfaeBzCvhL9w7WA9ro2vf8RtgqrIh0A24Z4/mtzY4B7wiA2cQ82D4PMtJa4QXtAWqCtFsDiDL9VPk3SBs1gWWan5lbi7pIDQsMzIaHD7MzDHGnKVFaTLgzrDi5PLypaVZbXSQOnXIEbOMSkwQ3AKv7gqcsicM+TxUyEkVrAENMBaSqWXEaIuOUktFYwos5q05wRPWd2+J9NVklv6y5AIUkHY0os+qssK8rsqVHwkSimA540b9mSVvhHuTGIUVgng0w1SWuuOzJNsPtohUh8Rw8hLhOW7KyAAEzIW0suw2uK793fNINmCtEvsTelnV4kPsDwB4rWBQy+Oazj6CCtQ4GQJbsLcYpuk6qJK0aQKkF4MB8cKWg1ZIJEUegtBNlybzBkY+5r1OyYVWmdzxeX8eeOrGa5/VdWNf1jpLRbur2sQGL7jVxpbYpsFMrGA/Eoq/OPpsw2jHxsAYYew/cxVh3QN05gje45YUvdyLJR3aZqav1pY6gaLWtK+WLxe0AY7izRxYy91NU+0+wCorc3m9hgJYNArScKJMckNk5FwWrcsq5IeL6XSFeJCpUCPzMvLmhqLZ3ufsgG6G19EHhQxshE8JRJQCpG/4Fpz8Z9W1Hg= X-Microsoft-Exchange-Diagnostics: 1;DM5PR03MB2698;6:bQvPbF8AfyV/yzShrSlmiW7XJ0Bvasq2vaLqo+8KmLdZJZTV9NjMqRjB4IXSIKz5CW5SYCFx8MScJ2jqNyY7fbR4jRJ5tDnY5IIY293PBvujXUPAg1PZHXMjorNvzkimnWVsut3bLm193I5SeVugOrW5rx4YJRYQT1NFkdbiDhfGEumXfdrvS7hQlxs0oIIR80n8KPmPJbbwUVjDfewxy+SaFBdfd6wppvJiR1AtZPNp5hf2qrsF+ahIJxMnPFWLSCnpLHzGjZOqWumG4MQTFiiQME/vJOmmxkgZljDoUu4aqbwf9WUWpTrul43O2D8h3k+wGSLro7OUvLP5vNOhTg==;5:f6IClcBGXsLaoU9Ikr1KmiPpBMtvNFIeSzWszHCRPKz4oeaOcMgBzXrqkrCIjXa68kO0uuBK3b8HjW6L69USY3i4Zea6Kt58EF7Vu4X9IYKTZ8uZo1ty3F6gWU7gyw9t2I52NK+bzzjaVB3h1tRQCg==;24:jXh8Qr9BCQRe+9PlTAA4p4N6aTNgsFwgwdPgUQgXNi43JEASVtEN+9YfMdzWgk+bwEOPbAJymXzoGxlpOmIvns4pOm2VY2nBiB2vyoY/vtQ=;7:2q2ylCsTCZL9j2qs21VfKXlneBr9L0KXuEk56tWJ2B/ZR7JZauWyJXhEh4zgCxF3kVCWvgLlAviPywWUUetU4sKQMZ3rsiww5rXd46QyAGj3cTI53FVphmMzE+De4PWY0B6gsDKf3kIyhjpUHgm4ogsjKd7t2tkAVdEBorlZLAEoG0CzrgowKDEMa2XQpU8vKg+VzUcKXXuBA02CqcrGAIE0Sfhy+KYxuLSy9s0mu4Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: analog.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2017 15:00:59.0663 (UTC) X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.57];Helo=[nwd2mta4.analog.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2698 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1072 Lines: 34 The serial interface can be reset by writing 32 consecutive 1s to the device. The value of 'ret' is overwritten when ad7793_check_platform_data() is called, so it should be initialized to -1 only before doing the spi_write(). Fixes: commit 2edb769d246e ("iio:ad7793: Add support for the ad7798 and ad7799") Signed-off-by: Dragos Bogdan --- drivers/iio/adc/ad7793.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c index e6706a09e100..8680abf72dd2 100644 --- a/drivers/iio/adc/ad7793.c +++ b/drivers/iio/adc/ad7793.c @@ -257,7 +257,7 @@ static int ad7793_setup(struct iio_dev *indio_dev, unsigned int vref_mv) { struct ad7793_state *st = iio_priv(indio_dev); - int i, ret = -1; + int i, ret; unsigned long long scale_uv; u32 id; @@ -266,6 +266,7 @@ static int ad7793_setup(struct iio_dev *indio_dev, return ret; /* reset the serial interface */ + ret = -1; ret = spi_write(st->sd.spi, (u8 *)&ret, sizeof(ret)); if (ret < 0) goto out; -- 2.11.0