Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753880AbdIDPqW (ORCPT ); Mon, 4 Sep 2017 11:46:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:37927 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753789AbdIDPqU (ORCPT ); Mon, 4 Sep 2017 11:46:20 -0400 Subject: Re: [PATCH v2] clk: mb86s7x: Drop non-building driver To: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Satoru OKAMOTO , Olof Johansson , Arnd Bergmann References: <20170824225237.21485-1-afaerber@suse.de> <20170901203201.GB21656@codeaurora.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <8601a2ec-33dc-0024-55ce-963f05faca75@suse.de> Date: Mon, 4 Sep 2017 17:46:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170901203201.GB21656@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2891 Lines: 61 Hi Stephen, Am 01.09.2017 um 22:32 schrieb Stephen Boyd: > On 08/25, Andreas Färber wrote: >> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol: >> >> drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No such file or directory >> #include >> ^~~~~~~~~~~~~~~~~~~~~~~ >> compilation terminated. >> >> And when commenting out that line, we get: >> >> drivers/clk/clk-mb86s7x.c: In function 'crg_gate_control': >> drivers/clk/clk-mb86s7x.c:72:8: error: implicit declaration of function 'mb86s7x_send_packet' [-Werror=implicit-function-declaration] >> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ, >> ^~~~~~~~~~~~~~~~~~~ >> drivers/clk/clk-mb86s7x.c:72:28: error: 'CMD_PERI_CLOCK_GATE_SET_REQ' undeclared (first use in this function) >> ret = mb86s7x_send_packet(CMD_PERI_CLOCK_GATE_SET_REQ, >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/clk/clk-mb86s7x.c:72:28: note: each undeclared identifier is reported only once for each function it appears in >> drivers/clk/clk-mb86s7x.c: In function 'crg_rate_control': >> drivers/clk/clk-mb86s7x.c:116:10: error: 'CMD_PERI_CLOCK_RATE_SET_REQ' undeclared (first use in this function) >> code = CMD_PERI_CLOCK_RATE_SET_REQ; >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/clk/clk-mb86s7x.c:121:10: error: 'CMD_PERI_CLOCK_RATE_GET_REQ' undeclared (first use in this function); did you mean 'CMD_PERI_CLOCK_RATE_SET_REQ'? >> code = CMD_PERI_CLOCK_RATE_GET_REQ; >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> CMD_PERI_CLOCK_RATE_SET_REQ >> drivers/clk/clk-mb86s7x.c: In function 'mhu_cluster_rate': >> drivers/clk/clk-mb86s7x.c:276:10: error: 'CMD_CPU_CLOCK_RATE_GET_REQ' undeclared (first use in this function) >> code = CMD_CPU_CLOCK_RATE_GET_REQ; >> ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/clk/clk-mb86s7x.c:278:10: error: 'CMD_CPU_CLOCK_RATE_SET_REQ' undeclared (first use in this function); did you mean 'CMD_CPU_CLOCK_RATE_GET_REQ'? >> code = CMD_CPU_CLOCK_RATE_SET_REQ; >> ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> CMD_CPU_CLOCK_RATE_GET_REQ >> cc1: some warnings being treated as errors >> scripts/Makefile.build:302: recipe for target >> 'drivers/clk/clk-mb86s7x.o' failed >> make[2]: *** [drivers/clk/clk-mb86s7x.o] Error 1 >> >> Remove the driver for now. >> >> Signed-off-by: Andreas Färber >> --- > > Applied to clk-next Thanks. Is this 4.14 or 4.15 material at this point? In particular I wonder which release I can proceed to introduce ARCH_MB86S7X in - I'm assuming we need to wait for this one to get merged, so 4.15 or 4.16 respectively? Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)