Subject: Re: [Intel-wired-lan] [PATCH] e1000e: changed some expensive calls of
 udelay to usleep_range
To: Matthew Tan <matthew.tan_1@nxp.com>
Cc: jeffrey.t.kirsher@intel.com, michael.kardonik@nxp.com,
        mitch.a.williams@intel.com, linux-kernel@vger.kernel.org,
        john.ronciak@intel.com, intel-wired-lan@lists.osuosl.org,
        netdev@vger.kernel.org
References: <1503503985-3869-1-git-send-email-matthew.tan_1@nxp.com>
From: Paul Menzel <pmenzel@molgen.mpg.de>
Message-ID: <fd5c453e-bd2e-3dc7-5f93-5af0ca216fd8@molgen.mpg.de>
Date: Mon, 4 Sep 2017 18:36:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1503503985-3869-1-git-send-email-matthew.tan_1@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1137
Lines: 31

Dear Matthew,


On 08/23/17 17:59, Matthew Tan wrote:
>      Calls to udelay are not preemtable by userspace so userspace
>      applications experience a large (~200us) latency when running on core
>      0. Instead usleep_range can be used to be more friendly to userspace
>      since it is preemtable. This is due to udelay using busy-wait loops
>      while usleep_rang uses hrtimers instead. It is recommended to use
>      udelay when the delay is <10us since at that precision overhead of
>      usleep_range hrtimer setup causes issues. However, the replaced calls
>      are for 50us and 100us so this should not be not an issue.

Is there a reason for indenting the paragraph. (I guess, you did `git 
show` or `git log -p` and copied the message?) Anyway, please remove 
whitespace in the front, if there is no reason.

Also, it looks like you ran benchmarks, so what is the delay for 
userspace applications with your changes?

> Signed-off-by: Matthew Tan <matthew.tan_1@nxp.com>
> ---
>   drivers/net/ethernet/intel/e1000e/phy.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

[…]


Kind regards,

Paul