Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754572AbdIDUIM (ORCPT ); Mon, 4 Sep 2017 16:08:12 -0400 Received: from mout.web.de ([212.227.17.12]:65235 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754531AbdIDUHd (ORCPT ); Mon, 4 Sep 2017 16:07:33 -0400 Subject: [PATCH 2/6] [media] atmel-isc: Improve a size determination in isc_formats_init() From: SF Markus Elfring To: linux-media@vger.kernel.org, Ludovic Desroches , Mauro Carvalho Chehab , Songjun Wu Cc: LKML , kernel-janitors@vger.kernel.org References: <88d0739c-fdc1-9d7d-fe53-b7c2eeed1849@users.sourceforge.net> Message-ID: <2b909a2d-0986-fb5e-f2d9-5d9c0fd71a06@users.sourceforge.net> Date: Mon, 4 Sep 2017 22:07:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <88d0739c-fdc1-9d7d-fe53-b7c2eeed1849@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:6C/LxDkw5wUY8KL8ORtwjKtMsNRxtt4wnnUn1ZU93hrkMS2O30w oCuk4pvI5urvKtymgpGe9j4HvdGnyBAXhJV/BzcRDNAdt13YEzPiYvejCUqjCsCa8eIpsvn mnN/AAD7XirUVuIk+VHKRv2lw0thlIko1x1vRYedD4ZVmy/AkLWFIRHDpKDxB+8PQ0+mumF 19n6a2COZqX3IQ5LmhI3Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:EKk533373gU=:fOTC0S4OIvPTjCoDfl0tvd TwygQoA/TlTwBx0c1plRvkjei6EGFaSedLuWT952Gie22Be3n1gJ/0QglhrL60v7H3liXvQAZ hp377+mvK2UMWE+mYzdqxqveAzk5UY5Tq7CwVO9v+ThgiAt7Lmc7kVE34kpwRT5zU/dMavyvO 7VaBadDIhPNyYcqcFs//LpJO7YzhNFKHfBd7K8buW7MXhJj7Yq/EsbxC2gMk49dfhiQlhVvla I/05gOqNfTJ81+oYOYfFvXlC9SVUGqrLcFovMyqFxOpahxcQJqsrYpmLjst2mfX7b9qX4BO0e pPhgUbtWR5X3gsUcI3MNICDS+ijxLv94ngRk7HkzLqFf9Rr2iFFGeyeHukg1tDbqucZ2FmClY dI+5cEmzLL1YwXUw3KvHCZFZtkxdR0XaAxMscM+I/3c5N9ayMegWfmRe+EatWtQQ2i5B5xnhG TeB/O5D+ZiIUTFk9082vyGbAlKHxJ1HFobKZhZq0ow202y3MvB7qs5JOIupHTl0H7WFUAS/FF 1nskRJwRnKTPx/4mZXNWShqf3lNST+6u+DAYF2FOVO+UhJ73nidoU33dH/B6HT+VQgciQ30/J +gYT1y3ZGUVtIE7fwZE+sxSXgovVwwDUaEJ8wHCEufmeVGnOiB9FuSFfLSJzarq8otsSzOIKh k5AQCLZt0ZFW3bbskg7BpDEjOHAM5hOVF3HJU/4gjhte6rMVIeyyyhlMPZqvZYdK1NFo0hw4g ZDRFW0nnZlo3a+nQcWN1uGCeoS5FB73O1+DKe/MBzKASylbISUuYMu3qcgfsxGGUrEhJC8yHI MhnxmdQhyNoI1SxlPC9DSNVPm8RZ48QDggXJUlLyM+A7sUBBFo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1005 Lines: 26 From: Markus Elfring Date: Mon, 4 Sep 2017 20:50:22 +0200 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/media/platform/atmel/atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c index f1e635edef72..f16bab0105c2 100644 --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -1505,6 +1505,6 @@ static int isc_formats_init(struct isc_device *isc) isc->num_user_formats = num_fmts; isc->user_formats = devm_kcalloc(isc->dev, - num_fmts, sizeof(struct isc_format *), + num_fmts, sizeof(*isc->user_formats), GFP_KERNEL); if (!isc->user_formats) -- 2.14.1