DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 200F421BB9
Date: Mon, 4 Sep 2017 19:34:36 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Joel Fernandes <joelaf@google.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@android.com,
        Ingo Molnar <mingo@redhat.com>,
        Byungchul Park <byungchul.park@lge.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 2/2] tracing: Add support for critical section events
Message-ID: <20170904193436.4a37fae4@gandalf.local.home>
In-Reply-To: <20170904194426.GD17526@worktop.programming.kicks-ass.net>
References: <20170903085051.6348-1-joelaf@google.com>
        <20170903085051.6348-3-joelaf@google.com>
        <20170904075614.bjkkrgyv2dpz7x5v@hirez.programming.kicks-ass.net>
        <CAJWu+opjZaN4d2-+0jD3QwO+jEXx16WdY0Y_CrP4xihyoemgPQ@mail.gmail.com>
        <20170904194426.GD17526@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 867
Lines: 21

On Mon, 4 Sep 2017 21:44:26 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> > I can change the name to something else, but at the moment I can't
> > think of anything better. Could you suggest a better name? Also btw,
> > 'critical timings' is the terminology used within the irqsoff tracer
> > so this is in line with that.  
> 
> So 'critical section' is what some mis-guided people call the locked
> region of a lock :-) Using it for something else is prone to cause more
> confusion...
> 
> I would simply call them what they are: irq_disable,irq_enable
> preempt_disable,preempt_enable.

Yes please. The "critical section" naming came from the code that was
from the latency tracer days of the real time patch (pre-ftrace). The
irqsoff tracer has the least modification from the original code, and
probably should be rewritten one of these days.

-- Steve