Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753819AbdIECYF (ORCPT ); Mon, 4 Sep 2017 22:24:05 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5961 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753650AbdIECYD (ORCPT ); Mon, 4 Sep 2017 22:24:03 -0400 Subject: Re: [RFC PATCH v1 2/3] apei: add ghes param for arch_apei_report_mem_error To: Borislav Petkov References: <1504261921-39308-1-git-send-email-xiexiuqi@huawei.com> <1504261921-39308-3-git-send-email-xiexiuqi@huawei.com> <20170901111526.plpslddmrjerkxtv@pd.tnic> CC: , , , , , , , , , , , , , , , , From: Xie XiuQi Message-ID: <98147131-acb6-0a9f-2fd6-043cb2ff410e@huawei.com> Date: Tue, 5 Sep 2017 10:20:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170901111526.plpslddmrjerkxtv@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.210] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.59AE09F1.0081,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 915e89bd618d1ced8498fd5b3a82db16 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2696 Lines: 80 Hi Borislav, On 2017/9/1 19:15, Borislav Petkov wrote: > n Fri, Sep 01, 2017 at 06:32:00PM +0800, Xie XiuQi wrote: >> Add ghes param for arch_apei_report_mem_error, with which >> we could do more arch-specific processing. >> >> Signed-off-by: Xie XiuQi >> --- >> arch/x86/kernel/acpi/apei.c | 2 +- >> drivers/acpi/apei/apei-base.c | 4 +++- >> drivers/acpi/apei/ghes.c | 2 +- >> include/acpi/apei.h | 4 +++- >> include/acpi/ghes.h | 3 ++- >> 5 files changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/arch/x86/kernel/acpi/apei.c b/arch/x86/kernel/acpi/apei.c >> index ea3046e..1bf1c9b 100644 >> --- a/arch/x86/kernel/acpi/apei.c >> +++ b/arch/x86/kernel/acpi/apei.c >> @@ -46,7 +46,7 @@ int arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data) >> return 1; >> } >> >> -void arch_apei_report_mem_error(int sev, struct cper_sec_mem_err *mem_err) >> +void arch_apei_report_mem_error(struct ghes *ghes, int sev, struct cper_sec_mem_err *mem_err) >> { >> #ifdef CONFIG_X86_MCE >> apei_mce_report_mem_error(sev, mem_err); >> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c >> index da370e1..317169b 100644 >> --- a/drivers/acpi/apei/apei-base.c >> +++ b/drivers/acpi/apei/apei-base.c >> @@ -38,6 +38,8 @@ >> #include >> #include >> >> +#include >> + >> #include "apei-internal.h" >> >> #define APEI_PFX "APEI: " >> @@ -770,7 +772,7 @@ int __weak arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, >> } >> EXPORT_SYMBOL_GPL(arch_apei_enable_cmcff); >> >> -void __weak arch_apei_report_mem_error(int sev, >> +void __weak arch_apei_report_mem_error(struct ghes *ghes, int sev, >> struct cper_sec_mem_err *mem_err) >> { >> } >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index fa9400d..996d16c4 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -483,7 +483,7 @@ static void ghes_do_proc(struct ghes *ghes, >> >> ghes_edac_report_mem_error(ghes, sev, mem_err); >> >> - arch_apei_report_mem_error(sev, mem_err); >> + arch_apei_report_mem_error(ghes, sev, mem_err); > > And next time you want to pass something else, you'll have to touch all > those files again... > > Instead, make that a notifier to which consumers register and define > a separate struct mem_err or ghes_err or whatnot and populate it with > cper_sec_mem_err data and whatever else is needed by the consumers. > Instead of passing that struct ghes * which consumers don't need to > know. OK, I'll add a notify chain here, thanks. > > Thx. > -- Thanks, Xie XiuQi