Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754124AbdIED0Q (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Sep 2017 23:26:16 -0400
Received: from mail-qk0-f181.google.com ([209.85.220.181]:35891 "EHLO
        mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753774AbdIED0O (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Sep 2017 23:26:14 -0400
X-Google-Smtp-Source: ADKCNb6NU0XabUkYGVZlvduvJftjGyDtB7RKeG9u+MWcGPMnH7b4XFhcW7q5WucoIcdKkUCOF6LO6CWF441JfnpGrNY=
MIME-Version: 1.0
In-Reply-To: <CAJWu+or9O1P=bvGH8i+8v_WEyiFtuQACS4dQWhu19HcdeieETA@mail.gmail.com>
References: <20170903085051.6348-1-joelaf@google.com> <20170903085051.6348-3-joelaf@google.com>
 <20170904075614.bjkkrgyv2dpz7x5v@hirez.programming.kicks-ass.net>
 <CAJWu+opjZaN4d2-+0jD3QwO+jEXx16WdY0Y_CrP4xihyoemgPQ@mail.gmail.com>
 <20170904194426.GD17526@worktop.programming.kicks-ass.net>
 <20170904193436.4a37fae4@gandalf.local.home> <CAJWu+or9O1P=bvGH8i+8v_WEyiFtuQACS4dQWhu19HcdeieETA@mail.gmail.com>
From: Joel Fernandes <joelaf@google.com>
Date: Mon, 4 Sep 2017 20:26:13 -0700
Message-ID: <CAJWu+opzANvRKkoyVxCtpNgV8HbVARVLQWtfjfdbCV4rjZyW_g@mail.gmail.com>
Subject: Re: [PATCH 2/2] tracing: Add support for critical section events
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@android.com,
        Ingo Molnar <mingo@redhat.com>,
        Byungchul Park <byungchul.park@lge.com>, Tejun Heo <tj@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1717
Lines: 57

On Mon, Sep 4, 2017 at 5:54 PM, Joel Fernandes <joelaf@google.com> wrote:
> On Mon, Sep 4, 2017 at 4:34 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
>> On Mon, 4 Sep 2017 21:44:26 +0200
>> Peter Zijlstra <peterz@infradead.org> wrote:
>>
>>> > I can change the name to something else, but at the moment I can't
>>> > think of anything better. Could you suggest a better name? Also btw,
>>> > 'critical timings' is the terminology used within the irqsoff tracer
>>> > so this is in line with that.
>>>
>>> So 'critical section' is what some mis-guided people call the locked
>>> region of a lock :-) Using it for something else is prone to cause more
>>> confusion...
>>>
>>> I would simply call them what they are: irq_disable,irq_enable
>>> preempt_disable,preempt_enable.
>>
>> Yes please. The "critical section" naming came from the code that was
>> from the latency tracer days of the real time patch (pre-ftrace). The
>> irqsoff tracer has the least modification from the original code, and
>> probably should be rewritten one of these days.
>
> Sounds good to me. For the subsystem, could you guys suggest a name? I
> was thinking "atomic_section"?
>
> Something like:
>
> subsystem: atomic_section
> events:
>   irqsoff_disable
>   irqsoff_enable
>   preemptoff_disable
>   preemptoff_enable
>
> and additionally (to do what my patch does):
>   preemptirqsoff_enable
>   preemptirqsoff_disable

Apologies, I meant (without the "off"):

subsystem: atomic_section
events:
  irqs_disable
  irqs_enable
  preempt_disable
  preempt_enable

and additionally (similar to what my patch does):
  preemptirq_enable
  preemptirq_disable


Could you let me know if we are in agreement about this naming?

thanks,

-Joel