Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754124AbdIEFXx (ORCPT ); Tue, 5 Sep 2017 01:23:53 -0400 Received: from terminus.zytor.com ([65.50.211.136]:48487 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbdIEFXv (ORCPT ); Tue, 5 Sep 2017 01:23:51 -0400 Date: Mon, 4 Sep 2017 22:20:14 -0700 From: tip-bot for Ravi Bangoria Message-ID: Cc: peterz@infradead.org, namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de, acme@redhat.com, mingo@kernel.org, ravi.bangoria@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, mpe@ellerman.id.au, alexander.shishkin@linux.intel.com, adrian.hunter@intel.com, hpa@zytor.com Reply-To: mingo@kernel.org, acme@redhat.com, ravi.bangoria@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, mpe@ellerman.id.au, adrian.hunter@intel.com, hpa@zytor.com, peterz@infradead.org, namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de In-Reply-To: <1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> References: <1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf test powerpc: Fix 'Object code reading' test Git-Commit-ID: 9a805d8648ee09c136130fe4114a09574bc0b1ef X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2088 Lines: 51 Commit-ID: 9a805d8648ee09c136130fe4114a09574bc0b1ef Gitweb: http://git.kernel.org/tip/9a805d8648ee09c136130fe4114a09574bc0b1ef Author: Ravi Bangoria AuthorDate: Thu, 31 Aug 2017 14:44:56 +0530 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Sep 2017 14:45:59 -0300 perf test powerpc: Fix 'Object code reading' test 'Object code reading' test always fails on powerpc guest. Two reasons for the failure are: 1. When elf section is too big (size beyond 'unsigned int' max value). objdump fails to disassemble from such section. This was fixed with commit 0f6329bd7fc ("binutils/objdump: Fix disassemble for huge elf sections") in binutils. 2. When the sample is from hypervisor. Hypervisor symbols can not be resolved within guest and thus thread__find_addr_map() fails for such symbols. Fix this by ignoring hypervisor symbols in the test. Signed-off-by: Ravi Bangoria Acked-by: Adrian Hunter Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Michael Ellerman Cc: Namhyung Kim Cc: Peter Zijlstra Cc: linuxppc-dev@lists.ozlabs.org Link: http://lkml.kernel.org/r/1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/code-reading.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c index 761c5a4..466a462 100644 --- a/tools/perf/tests/code-reading.c +++ b/tools/perf/tests/code-reading.c @@ -237,6 +237,11 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, thread__find_addr_map(thread, cpumode, MAP__FUNCTION, addr, &al); if (!al.map || !al.map->dso) { + if (cpumode == PERF_RECORD_MISC_HYPERVISOR) { + pr_debug("Hypervisor address can not be resolved - skipping\n"); + return 0; + } + pr_debug("thread__find_addr_map failed\n"); return -1; }