Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbdIEFgw (ORCPT ); Tue, 5 Sep 2017 01:36:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49088 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbdIEFgv (ORCPT ); Tue, 5 Sep 2017 01:36:51 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0A04E72D89 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=chuhu@redhat.com From: Chunyu Hu To: rostedt@goodmis.org Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, chuhu@redhat.com Subject: [PATCH] tracing: Fix clear of RECORDED_TGID flag when disabling trace event Date: Tue, 5 Sep 2017 13:36:46 +0800 Message-Id: <1504589806-8425-1-git-send-email-chuhu@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 05 Sep 2017 05:36:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 25 When disabling one trace event, the RECORDED_TGID flag in the event file is not correctly cleared. It's clearing RECORDED_CMD flag when it should clear RECORDED_TGID flag. Fix d914ba37("tracing: Add support for recording tgid of tasks") Signed-off-by: Chunyu Hu --- kernel/trace/trace_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index c93540c..8746839 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -406,7 +406,7 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file, if (file->flags & EVENT_FILE_FL_RECORDED_TGID) { tracing_stop_tgid_record(); - clear_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags); + clear_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags); } call->class->reg(call, TRACE_REG_UNREGISTER, file); -- 1.8.3.1