Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751850AbdIEFrN (ORCPT ); Tue, 5 Sep 2017 01:47:13 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36651 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbdIEFrJ (ORCPT ); Tue, 5 Sep 2017 01:47:09 -0400 Subject: Re: [PATCH 2/2] mm, memory_hotplug: remove timeout from __offline_memory To: Michal Hocko , Xishi Qiu References: <20170904082148.23131-1-mhocko@kernel.org> <20170904082148.23131-3-mhocko@kernel.org> <59AD15B6.7080304@huawei.com> <20170904090114.mrjxipvucieadxa6@dhcp22.suse.cz> <59AD174B.4020807@huawei.com> <20170904091505.xffd7orldpwlmrlx@dhcp22.suse.cz> Cc: Andrew Morton , KAMEZAWA Hiroyuki , Reza Arbab , Yasuaki Ishimatsu , Igor Mammedov , Vitaly Kuznetsov , linux-mm@kvack.org, LKML From: Anshuman Khandual Date: Tue, 5 Sep 2017 11:16:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170904091505.xffd7orldpwlmrlx@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17090505-0004-0000-0000-0000022C1771 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17090505-0005-0000-0000-00005E132ACB Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-05_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709050088 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1929 Lines: 40 On 09/04/2017 02:45 PM, Michal Hocko wrote: > On Mon 04-09-17 17:05:15, Xishi Qiu wrote: >> On 2017/9/4 17:01, Michal Hocko wrote: >> >>> On Mon 04-09-17 16:58:30, Xishi Qiu wrote: >>>> On 2017/9/4 16:21, Michal Hocko wrote: >>>> >>>>> From: Michal Hocko >>>>> >>>>> We have a hardcoded 120s timeout after which the memory offline fails >>>>> basically since the hot remove has been introduced. This is essentially >>>>> a policy implemented in the kernel. Moreover there is no way to adjust >>>>> the timeout and so we are sometimes facing memory offline failures if >>>>> the system is under a heavy memory pressure or very intensive CPU >>>>> workload on large machines. >>>>> >>>>> It is not very clear what purpose the timeout actually serves. The >>>>> offline operation is interruptible by a signal so if userspace wants >>>> Hi Michal, >>>> >>>> If the user know what he should do if migration for a long time, >>>> it is OK, but I don't think all the users know this operation >>>> (e.g. ctrl + c) and the affect. >>> How is this operation any different from other potentially long >>> interruptible syscalls? >>> >> Hi Michal, >> >> I means the user should stop it by himself if migration always retry in endless. > If the memory is migrateable then the migration should finish > eventually. It can take some time but it shouldn't be an endless loop. But what if some how the temporary condition (page removed from the PCP LRU list and has not been freed yet to the buddy) happens again and again. I understand we have schedule() and yield() to make sure that the context does not hold the CPU for ever but it can take theoretically very long time if not endless to finish. In that case sending signal to the user space process who initiated the offline request is the only way to stop this retry loop. I think this is still a better approach than the 120 second timeout which was kind of arbitrary.