Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbdIEGMy (ORCPT ); Tue, 5 Sep 2017 02:12:54 -0400 Received: from esa4.microchip.iphmx.com ([68.232.154.123]:39549 "EHLO esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbdIEGMw (ORCPT ); Tue, 5 Sep 2017 02:12:52 -0400 X-IronPort-AV: E=Sophos;i="5.41,478,1498546800"; d="scan'208";a="6542122" Date: Tue, 5 Sep 2017 08:11:34 +0200 From: Ludovic Desroches To: Ingo van Lil CC: Ludovic Desroches , , , , , , , , Subject: Re: [PATCH v2] clk: at91: utmi: set the mainck rate Message-ID: <20170905061134.f6n6jtvz57ycqd2f@rfolt0960.corp.atmel.com> Mail-Followup-To: Ingo van Lil , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, boris.brezillon@free-electrons.com, mturquette@baylibre.com, sboyd@codeaurora.org, nicolas.ferre@microchip.com, alexandre.belloni@free-electrons.com, linux-kernel@vger.kernel.org References: <20170904095226.29336-1-ludovic.desroches@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 23 On Mon, Sep 04, 2017 at 07:53:57PM +0200, Ingo van Lil wrote: > On 09/04/2017 11:52 AM, Ludovic Desroches wrote: > > > + /* SFR node missing is not necessarily an issue. */ > > + regmap_sfr = syscon_regmap_lookup_by_compatible("atmel,sama5d2-sfr"); > > + if (IS_ERR(regmap_sfr)) > > + regmap_sfr = NULL; > > What about SAMA5D3? That chip has an UTMICKTRIM register, too (SAMA5D4 > doesn't, though). Oh Yes. I'll look for atmel,sama5d3-sfr too. Maybe there is a smarter solution but I don't have it in mind. > > Otherwise the patch looks good and works fine on both my boards (SAMA5D2 > 16MHz and SAMA5D3 12MHz). Thanks for testing. Regards Ludovic