Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751054AbdIEGzh (ORCPT ); Tue, 5 Sep 2017 02:55:37 -0400 Received: from webclient5.webclient5.de ([136.243.32.179]:46253 "EHLO webclient5.webclient5.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbdIEGzg (ORCPT ); Tue, 5 Sep 2017 02:55:36 -0400 X-Greylist: delayed 484 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Sep 2017 02:55:35 EDT Subject: Re: [PATCH] hwmon: (k10temp) Add support for family 17h To: Guenter Roeck Cc: Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <1504575935-19476-1-git-send-email-linux@roeck-us.net> From: Clemens Ladisch Message-ID: <0565cf17-62d9-e319-8fe5-fbdf2d69335a@ladisch.de> Date: Tue, 5 Sep 2017 08:47:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504575935-19476-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=us-ascii Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 28 Guenter Roeck wrote: > Add support for temperature sensors on Family 17h (Ryzen) processors. > > Signed-off-by: Guenter Roeck > --- > Some of this is guesswork, but afaics it is working. No idea if there > is a better way to determine the temperature offset. The reported value is not an absolute temperature on any CPU. As far as I know, the offset is not guaranteed to be fixed for any model, i.e., it would be pointless to apply the offset observed on one specific chip. > @@ -25,6 +25,10 @@ > #include > #include > > +#ifndef PCI_DEVICE_ID_AMD_17H_DF_F3 > +#define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463 > +#endif > + Please move this down to the other symbols. Regards, Clemens