Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbdIEHKs (ORCPT ); Tue, 5 Sep 2017 03:10:48 -0400 Received: from smtpcmd04131.aruba.it ([62.149.158.131]:56531 "EHLO smtpcmd04131.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616AbdIEHKl (ORCPT ); Tue, 5 Sep 2017 03:10:41 -0400 X-Greylist: delayed 427 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Sep 2017 03:10:39 EDT Subject: Re: Support for BQ28Z610 Battery Monitor IC To: rajender.reddy@stesalit.in Cc: afd@ti.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, security@kernel.org, linux-api@vger.kernel.org, trivial@kernel.org References: From: Rodolfo Giometti Message-ID: <877fa5e7-2f4b-08a0-6d31-b128d56d119a@enneenne.com> Date: Tue, 5 Sep 2017 09:03:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 38 On 04/09/2017 15:53, rajender.reddy@stesalit.in wrote: > Dear Rodolfo Giometti, > > As discussed please find attached patch. > Please let me know if you need more details. It looks OK to me... however: - rewrite the patch's title as "power bq27xxx_battery: add support for BQ28Z610 battery monitor IC" - align the "=" characters as follow: + [BQ28Z610] = { + [BQ27XXX_REG_CTRL] = 0x00, + [BQ27XXX_REG_TEMP] = 0x06, + [BQ27XXX_REG_INT_TEMP] = INVALID_REG_ADDR, + [BQ27XXX_REG_VOLT] = 0x08, ... Then send the patch to the mail list or maintainers ad described into the MAINTAINERS file and adding me in Cc. Good job! :-) Ciao, Rodolfo -- HCE Engineering e-mail: giometti@hce-engineering.it GNU/Linux Solutions giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Cosino Project - the quick prototyping embedded system - www.cosino.it Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it