Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751478AbdIEHi7 (ORCPT ); Tue, 5 Sep 2017 03:38:59 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:32920 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbdIEHix (ORCPT ); Tue, 5 Sep 2017 03:38:53 -0400 X-Google-Smtp-Source: ADKCNb73v3z1QSjkG9jZ8ButKiKNkkvM13eznr+Wh2AOucUK/RdSxig96eli3N6bZsUQvFUfAkXzPg== Date: Tue, 5 Sep 2017 08:38:49 +0100 From: Lee Jones To: sathyanarayanan.kuppuswamy@linux.intel.com Cc: souvik.k.chakravarty@intel.com, x86@kernel.org, mingo@redhat.com, qipeng.zha@intel.com, hpa@zytor.com, dvhart@infradead.org, tglx@linutronix.de, andy@infradead.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, sathyaosid@gmail.com Subject: Re: [RFC v2 6/6] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls Message-ID: <20170905073849.eeeo3kbncozzer46@dell> References: <1504401889-113524-7-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1504401889-113524-7-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1304 Lines: 35 On Sat, 02 Sep 2017, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Removed redundant IPC helper functions and refactored the driver to use > generic IPC device driver APIs. > > This patch also cleans-up PMC IPC user drivers to use APIs provided > by generic IPC driver. > > Signed-off-by: Kuppuswamy Sathyanarayanan > --- > arch/x86/include/asm/intel_pmc_ipc.h | 37 +-- > drivers/mfd/intel_soc_pmic_bxtwc.c | 24 +- > include/linux/mfd/intel_soc_pmic.h | 2 + I'm a bit concerned by the API. Any reason why you're not using pointers for addresses? And for the arguments where you are using pointers, you should be using NULL, instead of 0. > drivers/platform/x86/intel_pmc_ipc.c | 364 +++++++++----------------- > drivers/platform/x86/intel_telemetry_pltdrv.c | 114 ++++---- > 5 files changed, 215 insertions(+), 326 deletions(-) > > Changes since v1: > * Removed custom APIs. > * Cleaned up PMC IPC user drivers to use APIs provided by generic > IPC driver. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog