Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263398AbTGFUTY (ORCPT ); Sun, 6 Jul 2003 16:19:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263407AbTGFUTY (ORCPT ); Sun, 6 Jul 2003 16:19:24 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:64131 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S263398AbTGFUTX (ORCPT ); Sun, 6 Jul 2003 16:19:23 -0400 Message-ID: <3F08879D.4070300@pobox.com> Date: Sun, 06 Jul 2003 16:33:33 -0400 From: Jeff Garzik Organization: none User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk X-Accept-Language: en MIME-Version: 1.0 To: Paul Clements CC: akpm@digeo.com, linux-kernel@vger.kernel.org Subject: Re: [PATCHES 2.5.74-mm2] misc. nbd cleanups/fixes References: <3F088277.3EB39CE2@SteelEye.com> In-Reply-To: <3F088277.3EB39CE2@SteelEye.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 27 Paul Clements wrote: > The two attached patches are: > > 1) nbd-remove_open_release.diff - remove the unneeded nbd_open and > nbd_release functions Please remove the unneeded ->refcnt member as well. > 2) nbd-block_layer_compat.diff - ensure that nbd and the block layer > agree about device block sizes and total device sizes Use set_blocksize, please. Also, please split up your patches further. The Linux (Linus?) standard is one patch per email... Also, attachments are discouraged, though not a "no no" because of various broken corporate email systems... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/