Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbdIELE6 (ORCPT ); Tue, 5 Sep 2017 07:04:58 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:42323 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbdIELEy (ORCPT ); Tue, 5 Sep 2017 07:04:54 -0400 Date: Tue, 5 Sep 2017 13:04:52 +0200 From: Maxime Ripard To: Antony Antony Cc: Chen-Yu Tsai , Icenowy Zheng , linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v5] arm64: allwinner: h5: add support for NanoPi NEO Plus2 Message-ID: <20170905110452.fa6l6x3jrrdod7b7@flea> References: <20170824231716.2623-1-antony@phenome.org> <20170830125057.38529-1-antony@phenome.org> <20170831145859.rief3fqo36ns23rm@flea> <20170901105313.m26y2re3ulskua43@AntonyAntony.local> <20170904082732.g2q2tjd6qlvhaea7@flea> <20170904142619.zq4x2l2qwtpukdc7@AntonyAntony.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6estbauo2z4lk3ai" Content-Disposition: inline In-Reply-To: <20170904142619.zq4x2l2qwtpukdc7@AntonyAntony.local> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4076 Lines: 128 --6estbauo2z4lk3ai Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Antony, On Mon, Sep 04, 2017 at 04:26:19PM +0200, Antony Antony wrote: > On Mon, Sep 04, 2017 at 10:27:32AM +0200, Maxime Ripard wrote: > > On Fri, Sep 01, 2017 at 12:53:13PM +0200, Antony Antony wrote: > > > > > +&emac { > > > > > + pinctrl-names =3D "default"; > > > > > + pinctrl-0 =3D <&emac_rgmii_pins>; > > > > > + phy-supply =3D <®_gmac_3v3>; > > > > > + phy-handle =3D <&ext_rgmii_phy>; > > > > > + phy-mode =3D "rgmii"; > > > > > + status =3D "okay"; > > > > > +}; > > > > > + > > > > > +&mdio { > > > > > + ext_rgmii_phy: ethernet-phy@7 { > > > > > + compatible =3D "ethernet-phy-ieee802.3-c22"; > > > > > + reg =3D <7>; > > > > > + }; > > > > > +}; > > > >=20 > > > > This will not compile. > > >=20 > > > I don't understand you, because, v5 file compiled for me. Here is out= put=20 > > > from running system, just the relevant part. using dtc -I fs=20 > > > /proc/device-tree > > >=20 > > > ext_rgmii_phy =3D "/soc/ethernet@1c30000/mdio/ethernet-phy@7"; > > >=20 > > > ethernet@1c30000 { > > > mdio { > > > .. > > > ethernet-phy@7 { > > > compatible =3D "ethernet-phy-ieee802.3-c22"; > > > phandle =3D <0x1c>; > > > reg =3D <0x7>; > > > linux,phandle =3D <0x1c>; > > > }; > > > }; > > >=20 > > > Is this what you expect? > >=20 > > The bindings have been reverted recently, so if you based your work on > > a version between 4.13-rc1 and 4.13-rc6 it will work, but anything > > more recent will not compile anymore. >=20 > I deleted emc and related node. > I see. I hope stmmac: sun8i come back soon. It works well well on this=20 > board, running 4.13-rc6 Yeah, I hope too. Unfortunately, the DT bindings were still under discussion after it's been merged, so we couldn't guarantee their stability in the future. > > > > > +&usb_otg { > > > > > + dr_mode =3D "host"; > > > > > + status =3D "okay"; > > > > > +}; > > > > > + > > > > > +&usbphy { > > > > > + /* USB Type-A ports' VBUS is always on */ > > > > > + usb0_id_det-gpios =3D <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */ > > > >=20 > > > > If it has an ID-detect pin, then it's not a host-only USB OTG > > > > controller. dr_mode should be set to otga=20 > > >=20 > > > good point. I don't see an ID-detect connected in the schematic. The= =20 > > > previous generation had.=20 > > >=20 > > > I will leave=20 > > > &usb_otg { > > > dr_mode =3D "host"; > > > status =3D "okay"; > > > }; > > >=20 > > > &usbphy { > > > /* USB Type-A ports' VBUS is always on */ > > > status =3D "okay"; > > > }; > >=20 > > Looking at the schematics, it seems that the micro USB isn't even > > wired to a bus but is only used to power the board. If so, you can > > even remove the usb_otg node. >=20 > Yes, the Micro USB data pins are not connected. However, it there is a=20 > second USB A port connected to the processor. If I remove &usb_otg node, = in=20 > 4.13-rc6, the second port goes to disabled. Ok, someone got creative :) Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --6estbauo2z4lk3ai Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZroTUAAoJEBx+YmzsjxAg094P/25W9Ik8tR3yLWWtCJrtV4gA 2tFvparPua+kwBiy4Xm7GQbq8WRDsCalG4h4/93JZsSU1xqrIyZxhQA8ufcaVhtI sBmkEjFZqTHSOyrvHrwfDq2G86efmRtsv8/Sj/UewHBHnQOdyssQRMEcLCzCtlZt v6aQl6LBs0HTdU6MXB/2ITQV/tnQrUZ3K8nflIJa1a00Mezxo4tMgLsEPP7BT5Wy 2nDEeKMk+Az/6UiKLRxoH/yAGZ+4sJf1FPTyYX0w+ApCYOvmg4B88ZbTVgoo89Zj A4GFzGwcp9kqsbmqfKAT+sYTYc0SpnaamsDgXubPzt+ztjPYn9AgY/+SGgTwpnZ9 GKvssdZbX7q7hR0Xy/WymxzYAgVa8MW6QzujKeqDMVdQ0T3QHaC0HoXUR4NuBeTJ FLGNMcwmPF5OE7aQ/Tk50TpPGTCkgQd0BHP2csHa6w7A8e1b3XwfzCyg4e1A7NjL AAM1bH1Dgpj1AVMjARbJ7OuDgZVJ8WDMg+M9ZMz6qFNNO+zn4+SyPf3I5UzRTsoP dt/5TuQh/TCOSzgS5G0b1RqmmJm8KrZp8DsUVGikdIVqre5SnOM2wp6fHAH4UVVC 7TI1qf5EbKU1st7o41djL+EFbvE7wfA1kX6qdqT00Gwr3FR3vERhed9r0zaNyJJq zHY4zMosfScuxFDvPMhh =lWyl -----END PGP SIGNATURE----- --6estbauo2z4lk3ai--