Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751692AbdIELJX (ORCPT ); Tue, 5 Sep 2017 07:09:23 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:42745 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbdIELJT (ORCPT ); Tue, 5 Sep 2017 07:09:19 -0400 Date: Tue, 5 Sep 2017 13:09:17 +0200 From: Maxime Ripard To: Antony Antony Cc: Chen-Yu Tsai , Icenowy Zheng , linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH v8] arm64: allwinner: h5: add NanoPi NEO Plus2 DT support Message-ID: <20170905110917.pjf22akyqiytx3iu@flea> References: <20170824231716.2623-1-antony@phenome.org> <20170904143014.46904-1-antony@phenome.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cvybrtc2rgscf7tr" Content-Disposition: inline In-Reply-To: <20170904143014.46904-1-antony@phenome.org> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2302 Lines: 87 --cvybrtc2rgscf7tr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Antony, Almost good, I'm sorry I missed a few things before. On Mon, Sep 04, 2017 at 04:30:14PM +0200, Antony Antony wrote: > +&mmc1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc1_pins_a>; > + vmmc-supply =3D <®_vcc3v3>; > + vqmmc-supply =3D <®_vcc3v3>; > + mmc-pwrseq =3D <&wifi_pwrseq>; > + bus-width =3D <4>; > + non-removable; > + status =3D "okay"; Please add a new line here. > + brcmf: wifi@1 { > + reg =3D <1>; > + compatible =3D "brcm"; This should be the actual compatible, not just the vendor. > + }; > +}; > + > +&mmc2 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&mmc2_8bit_pins>; > + vmmc-supply =3D <®_vcc3v3>; > + bus-width =3D <8>; > + non-removable; > + cap-mmc-hw-reset; > + boot_device =3D <0>; that property should still be removed. > +&r_pio { > + leds_r_npi: led_pins@0 { > + pins =3D "PL10"; > + function =3D "gpio_out"; > + }; > + > + vdd_cpux_r_npi: regulator_pins@0 { > + allwinner,pins =3D "PL6"; > + allwinner,function =3D "gpio_out"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > +}; And these must be left out. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --cvybrtc2rgscf7tr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZroXdAAoJEBx+YmzsjxAgZoYP/1hW++BO6EGVWb5hw3eykDKc ZcV0+AWvQWV8pAj9SFbRlZqBppek7NECgnapwZukM5z+cJYQrh/349cHGJHGCzIb LxZOK0af+XAOh8q/wgOMbaWv1tJDr5cxyu6XODeIGDwj6YAe3Id0FvWF3QxY5Eqm nw5T8I7kAhByygQPtyyZgt1bP6fvhfkapiC4ILRbxd5iZ3FeD2dmcZzDBU7sf0Db FgoctRceOy3SFx4K0mB/phFWD1Asxb0xSTx5dWs2i8J2nZIHglFVO6lOirIcfMwc dVEGgQ+rI+8WVthlBexzbxf4cXD1VyNAMXeuzWocuVJOVltb1bfosiaNFoHMJkDy wpFgFnrJ7ukGlX7QPrf2B43CCQQb4+GP47IFO5PRJtzmLC70hR/QZiLq5PnQhhE7 myBEVYLyEfUVrTX8XAUVGNhxpxTEkJba2juWBa+pFAAkJ4Cz4xhKWIU53dd8r48H Cwxnhc6zl22/9eSixMyGrsIYIpt4DYdXicY3gH7WuEVvyw6dInXklwcl+oqxCckA 2blkAR4zSG6TTRZ2Sd9OednDrYpGi+Oi+T4lfmw4Iz0uFbz9qb1bxNSWDjstPp1l rg2j1nWIw16vMRb1LE2Uz6lrD03HUdgCnsnC4qSgOyD3EzZmsG0kPlLOn+PpAgAR HtTZJqpnfY9g1h3fRP/q =MG6i -----END PGP SIGNATURE----- --cvybrtc2rgscf7tr--