Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751721AbdIEMuR (ORCPT ); Tue, 5 Sep 2017 08:50:17 -0400 Received: from foss.arm.com ([217.140.101.70]:40226 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbdIEMuA (ORCPT ); Tue, 5 Sep 2017 08:50:00 -0400 Subject: Re: [RFC PATCH 4/6] iommu/arm-smmu-v3: Add SVM support for platform devices To: Yisheng Xie Cc: joro@8bytes.org, robh+dt@kernel.org, mark.rutland@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, will.deacon@arm.com, robin.murphy@arm.com, robert.moore@intel.com, lv.zheng@intel.com, iommu@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devel@acpica.org, liubo95@huawei.com, chenjiankang1@huawei.com, xieyisheng@huawei.com References: <1504167642-14922-1-git-send-email-xieyisheng1@huawei.com> <1504167642-14922-5-git-send-email-xieyisheng1@huawei.com> From: Jean-Philippe Brucker Message-ID: <039adc54-00f5-bf4e-e509-ffdc67baa15e@arm.com> Date: Tue, 5 Sep 2017 13:53:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1504167642-14922-5-git-send-email-xieyisheng1@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 21 On 31/08/17 09:20, Yisheng Xie wrote: > From: Jean-Philippe Brucker > > Platform device can realise SVM function by using the stall mode. That > is to say, when device access a memory via iova which is not populated, > it will stalled and when SMMU try to translate this iova, it also will > stall and meanwhile send an event to CPU via MSI. > > After SMMU driver handle the event and populated the iova, it will send > a RESUME command to SMMU to exit the stall mode, therefore the platform > device can contiue access the memory. > > Signed-off-by: Jean-Philippe Brucker No. Please don't forge a signed-off-by under a commit message you wrote, it's rude. I didn't sign it, didn't consider it fit for mainline or even as an RFC, and wanted to have another read before sending. My mistake, I'll think twice before sharing prototypes in the future. Thanks, Jean