Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbdIENZa (ORCPT ); Tue, 5 Sep 2017 09:25:30 -0400 Received: from forward2o.cmail.yandex.net ([37.9.109.243]:54900 "EHLO forward2o.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbdIENZY (ORCPT ); Tue, 5 Sep 2017 09:25:24 -0400 Authentication-Results: mxback8g.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Arvind Yadav , "gregkh@linuxfoundation.org" Cc: "linux-kernel@vger.kernel.org" , kernel-janitors In-Reply-To: References: <22fa8ca67a6d4a59997f463bf241ed56596fbcfa.1502526524.git.arvind.yadav.cs@gmail.com> Subject: Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error MIME-Version: 1.0 Message-Id: <188621504617921@web52g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 05 Sep 2017 16:25:21 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1126 Lines: 36 Hi Arvind 12.08.2017, 11:38, "Arvind Yadav" : > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Fix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav Looks good to me, thank you kernel-janitors@ please queue this up Acked-by: Evgeniy Polyakov > --- >  drivers/w1/masters/ds2490.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c > index 46ccb2f..a02da9a 100644 > --- a/drivers/w1/masters/ds2490.c > +++ b/drivers/w1/masters/ds2490.c > @@ -1088,7 +1088,7 @@ static void ds_disconnect(struct usb_interface *intf) >          kfree(dev); >  } > > -static struct usb_device_id ds_id_table [] = { > +static const struct usb_device_id ds_id_table[] = { >          { USB_DEVICE(0x04fa, 0x2490) }, >          { }, >  }; > -- > 2.7.4