Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751933AbdIENob (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Sep 2017 09:44:31 -0400
Received: from foss.arm.com ([217.140.101.70]:40922 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751871AbdIENoZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Sep 2017 09:44:25 -0400
Cc: Sudeep Holla <sudeep.holla@arm.com>, Nishanth Menon <nm@ti.com>,
        Harb Abdulhamid <harba@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Ryan Harkin <Ryan.Harkin@arm.com>, Roy Franz <roy.franz@cavium.com>,
        Loc Ho <lho@apm.com>, Alexey Klimov <alexey.klimov@arm.com>
Subject: Re: [PATCH v2 04/18] firmware: arm_scmi: add common infrastructure
 and support for base protocol
To: Julien Thierry <julien.thierry@arm.com>,
        ALKML <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, DTML <devicetree@vger.kernel.org>
References: <1501857104-11279-1-git-send-email-sudeep.holla@arm.com>
 <1501857104-11279-5-git-send-email-sudeep.holla@arm.com>
 <9a6b0722-1299-fb0a-6c75-9aceb248659f@arm.com>
From: Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <42d72579-07cd-798d-34e9-b9c584048b64@arm.com>
Date: Tue, 5 Sep 2017 14:45:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <9a6b0722-1299-fb0a-6c75-9aceb248659f@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1642
Lines: 50



On 05/09/17 14:39, Julien Thierry wrote:

[...]

>> diff --git a/drivers/firmware/arm_scmi/driver.c
>> b/drivers/firmware/arm_scmi/driver.c
>> index 139d6980f270..601d0d7210d9 100644
>> --- a/drivers/firmware/arm_scmi/driver.c
>> +++ b/drivers/firmware/arm_scmi/driver.c
>> @@ -108,18 +108,22 @@ struct scmi_desc {
>>    * @dev: Device pointer
>>    * @desc: SoC description for this instance
>>    * @handle: Instance of SCMI handle to send to clients
>> + * @version: SCMI revision information containing protocol version,
>> + *    implementation version and (sub-)vendor identification.
>>    * @cl: Mailbox Client
>>    * @tx_chan: Transmit mailbox channel
>>    * @rx_chan: Receive mailbox channel
>>    * @tx_payload: Transmit mailbox channel payload area
>>    * @rx_payload: Receive mailbox channel payload area
>>    * @minfo: Message info
>> + * @protocols_imp: list of protocols implemented
>>    * @node: list head
>>    * @users: Number of users of this instance
>>    */
>>   struct scmi_info {
>>       struct device *dev;
>>       const struct scmi_desc *desc;
>> +    struct scmi_revision_info version;
>>       struct scmi_handle handle;
>>       struct mbox_client cl;
>>       struct mbox_chan *tx_chan;
>> @@ -127,6 +131,7 @@ struct scmi_info {
>>       void __iomem *tx_payload;
>>       void __iomem *rx_payload;
>>       struct scmi_xfers_info minfo;
>> +    u8 *protocols_imp;
> 
> Both the base protocol and driver part rely on this being of size
> MAX_PROTOCOLS_IMP (if existing).
> 
> Could this be a "u8 protocols_imp[MAX_PROTOCOLS_IMP]" instead? 

Sounds better, will update accordingly.

-- 
Regards,
Sudeep