Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751499AbdIEOOc (ORCPT ); Tue, 5 Sep 2017 10:14:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57158 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbdIEOOb (ORCPT ); Tue, 5 Sep 2017 10:14:31 -0400 Date: Tue, 5 Sep 2017 16:14:32 +0200 From: Greg KH To: Janani Sankara Babu Cc: devel@driverdev.osuosl.org, goudapatilk@gmail.com, insafonov@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Message-ID: <20170905141432.GB29729@kroah.com> References: <1504606001-31970-1-git-send-email-jananis37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504606001-31970-1-git-send-email-jananis37@gmail.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 893 Lines: 21 On Tue, Sep 05, 2017 at 03:36:41PM +0530, Janani Sankara Babu wrote: > This patch solves the following warning shown by checkpatch script > Warning: msleep < 20ms can sleep for up to 20ms > > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c > index f86c9ce..78edc15 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c > +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c > @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) > DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms); > break; > } > - msleep(1); > + usleep_range(0, 1000); How do you know this is a valid range to sleep for?