Message-ID: <1504621010.28899.6.camel@perches.com>
Subject: Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms
From: Joe Perches <joe@perches.com>
To: Janani Sankara Babu <jananis37@gmail.com>, gregkh@linuxfoundation.org
Cc: goudapatilk@gmail.com, insafonov@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Tue, 05 Sep 2017 07:16:50 -0700
In-Reply-To: <1504606001-31970-1-git-send-email-jananis37@gmail.com>
References: <1504606001-31970-1-git-send-email-jananis37@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 755
Lines: 21

On Tue, 2017-09-05 at 15:36 +0530, Janani Sankara Babu wrote:
> This patch solves the following warning shown by checkpatch script
> Warning: msleep < 20ms can sleep for up to 20ms 
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
[]
> @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
>  			DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
>  			break;
>  		}
> -		msleep(1);
> +		usleep_range(0, 1000);

No, that would sleep a random time up to 1 ms.

usleep_range(1000, 2000) might be OK but please
check the value passed as delay_ms.

It's only used as LPS_LEAVE_TIMEOUT_MS (100 here)
so it seems just fine to keep using msleep.