Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbdIEP7z (ORCPT ); Tue, 5 Sep 2017 11:59:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:50754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbdIEP7y (ORCPT ); Tue, 5 Sep 2017 11:59:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9348521483 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 5 Sep 2017 11:59:51 -0400 From: Steven Rostedt To: Chunyu Hu Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, Joel Fernandes Subject: Re: [PATCH] tracing: Fix clear of RECORDED_TGID flag when disabling trace event Message-ID: <20170905115951.2765f912@gandalf.local.home> In-Reply-To: <1504589806-8425-1-git-send-email-chuhu@redhat.com> References: <1504589806-8425-1-git-send-email-chuhu@redhat.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 31 On Tue, 5 Sep 2017 13:36:46 +0800 Chunyu Hu wrote: > When disabling one trace event, the RECORDED_TGID flag in the event > file is not correctly cleared. It's clearing RECORDED_CMD flag when > it should clear RECORDED_TGID flag. Fix d914ba37("tracing: Add support > for recording tgid of tasks") > > Signed-off-by: Chunyu Hu Thanks! Applied. -- Steve > --- > kernel/trace/trace_events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index c93540c..8746839 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -406,7 +406,7 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file, > > if (file->flags & EVENT_FILE_FL_RECORDED_TGID) { > tracing_stop_tgid_record(); > - clear_bit(EVENT_FILE_FL_RECORDED_CMD_BIT, &file->flags); > + clear_bit(EVENT_FILE_FL_RECORDED_TGID_BIT, &file->flags); > } > > call->class->reg(call, TRACE_REG_UNREGISTER, file);