Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752094AbdIEQD4 (ORCPT ); Tue, 5 Sep 2017 12:03:56 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:54504 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdIEQDz (ORCPT ); Tue, 5 Sep 2017 12:03:55 -0400 Date: Tue, 5 Sep 2017 18:03:41 +0200 From: Peter Zijlstra To: Alexey Budankov Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Andi Kleen , Kan Liang , Dmitri Prokhorov , Valery Cherepennikov , Mark Rutland , Stephane Eranian , David Carrillo-Cisneros , linux-kernel , Vince Weaver , Thomas Gleixner Subject: Re: [RFC][PATCH] perf: Rewrite enabled/running timekeeping Message-ID: <20170905160341.jpq6il7gux7bmd3e@hirez.programming.kicks-ass.net> References: <20170822204743.GR32112@worktop.programming.kicks-ass.net> <2a426aa2-42c8-e839-1cec-aa3971651f3e@linux.intel.com> <20170831171837.njnc6r6elsvkl7lt@hirez.programming.kicks-ass.net> <46f72a3f-f18b-0227-3d78-fb23c8a6e18e@linux.intel.com> <20170904120843.oazlv73phoxoinlj@hirez.programming.kicks-ass.net> <385005b6-51ea-383e-df81-43365f3f5152@linux.intel.com> <20170904154145.xl4fyg7vhgbnmhwi@hirez.programming.kicks-ass.net> <9c3c1fc7-5a2e-2745-dab1-390dc7d58d50@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 542 Lines: 14 On Tue, Sep 05, 2017 at 03:06:26PM +0300, Alexey Budankov wrote: > [ 6614.226305] WARNING: CPU: 45 PID: 43385 at kernel/events/core.c:239 event_function+0xb3/0xe0 I think I avoided that problem by not radically rewriting perf_event_read() but fixing it instead: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=perf/core&id=8ad650955ede95e4a6fd6afbda2a0b37d4af9c29 Full tree at: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/core Very minimally tested so far, I'll continue tomorrow.