From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Pali =?iso-8859-1?Q?Roh=E1r?= <pali.rohar@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Changing FAT label of mounted file system
References: <201709051614.58774@pali>
Date: Wed, 06 Sep 2017 00:35:10 +0900
In-Reply-To: <201709051614.58774@pali> ("Pali =?iso-8859-1?Q?Roh=E1r=22's?=
 message of "Tue, 5 Sep
        2017 16:14:58 +0200")
Message-ID: <87a8295fbl.fsf@devron>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1020
Lines: 29

Pali Roh?r <pali.rohar@gmail.com> writes:

> Hello!

Hi,

> On most file system it is possible to change its label at anytime, when 
> mounted or unmounted. But FAT is such special file system on which is 
> label stored in two location, plus one is in directory structure (which 
> cannot be modified when file system is mounted).
>
> I would like to ask what about providing FAT specific IOCTL for vfat 
> kernel driver which would allow to change volume label?

I have no objection to add this ioctl though, there is really needs of
apps?

For example, ext4's volume name is sb->s_volume_name, right? And no
ioctl to change it, so I guess the app does read-modify-write
superblock. If so, there is theoretical race with umount and super block
update of ext4 (yes, although updating superblock is rare timing).  So
ext4 is unsafe actually to rewrite volume_name on the mounted fs.

Well, anyway, if there is the patch to add ioctl, again, I have no
objection.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>