Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752106AbdIEQVV (ORCPT ); Tue, 5 Sep 2017 12:21:21 -0400 Received: from g2t1383g.austin.hpe.com ([15.233.16.89]:39863 "EHLO g2t1383g.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbdIEQVU (ORCPT ); Tue, 5 Sep 2017 12:21:20 -0400 Date: Tue, 5 Sep 2017 11:21:12 -0500 From: Dimitri Sivanich To: jglisse@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dimitri Sivanich , "Kirill A . Shutemov" , Andrew Morton , Linus Torvalds , Andrea Arcangeli Subject: Re: [PATCH 10/13] sgi-gru: update to new mmu_notifier semantic Message-ID: <20170905162112.GC14176@hpe.com> References: <20170831211738.17922-1-jglisse@redhat.com> <20170831211738.17922-11-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170831211738.17922-11-jglisse@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2094 Lines: 55 Acked-by: Dimitri Sivanich On Thu, Aug 31, 2017 at 05:17:35PM -0400, jglisse@redhat.com wrote: > From: J?r?me Glisse > > Call to mmu_notifier_invalidate_page() are replaced by call to > mmu_notifier_invalidate_range() and thus call are bracketed by > call to mmu_notifier_invalidate_range_start()/end() > > Remove now useless invalidate_page callback. > > Signed-off-by: J?r?me Glisse > Cc: Dimitri Sivanich > Cc: Jack Steiner > Cc: Kirill A. Shutemov > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: Andrea Arcangeli > --- > drivers/misc/sgi-gru/grutlbpurge.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/misc/sgi-gru/grutlbpurge.c b/drivers/misc/sgi-gru/grutlbpurge.c > index e936d43895d2..9918eda0e05f 100644 > --- a/drivers/misc/sgi-gru/grutlbpurge.c > +++ b/drivers/misc/sgi-gru/grutlbpurge.c > @@ -247,17 +247,6 @@ static void gru_invalidate_range_end(struct mmu_notifier *mn, > gru_dbg(grudev, "gms %p, start 0x%lx, end 0x%lx\n", gms, start, end); > } > > -static void gru_invalidate_page(struct mmu_notifier *mn, struct mm_struct *mm, > - unsigned long address) > -{ > - struct gru_mm_struct *gms = container_of(mn, struct gru_mm_struct, > - ms_notifier); > - > - STAT(mmu_invalidate_page); > - gru_flush_tlb_range(gms, address, PAGE_SIZE); > - gru_dbg(grudev, "gms %p, address 0x%lx\n", gms, address); > -} > - > static void gru_release(struct mmu_notifier *mn, struct mm_struct *mm) > { > struct gru_mm_struct *gms = container_of(mn, struct gru_mm_struct, > @@ -269,7 +258,6 @@ static void gru_release(struct mmu_notifier *mn, struct mm_struct *mm) > > > static const struct mmu_notifier_ops gru_mmuops = { > - .invalidate_page = gru_invalidate_page, > .invalidate_range_start = gru_invalidate_range_start, > .invalidate_range_end = gru_invalidate_range_end, > .release = gru_release, > -- > 2.13.5 >