Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752309AbdIEQmn (ORCPT ); Tue, 5 Sep 2017 12:42:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41462 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbdIEQmj (ORCPT ); Tue, 5 Sep 2017 12:42:39 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD92CC0753CC Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com From: Hans de Goede To: MyungJoo Ham , Chanwoo Choi , Guenter Roeck , Heikki Krogerus , Darren Hart , Andy Shevchenko , Peter Rosin , Mathias Nyman Cc: Hans de Goede , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org, Kuppuswamy Sathyanarayanan , Sathyanarayanan Kuppuswamy Natarajan , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: [PATCH v2 02/11] mux: core: Add support for getting a mux controller on a non DT platform Date: Tue, 5 Sep 2017 18:42:12 +0200 Message-Id: <20170905164221.11266-3-hdegoede@redhat.com> In-Reply-To: <20170905164221.11266-1-hdegoede@redhat.com> References: <20170905164221.11266-1-hdegoede@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 05 Sep 2017 16:42:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5487 Lines: 181 On non DT platforms we cannot get the mux_chip by pnode. Other subsystems (regulator, clock, pwm) have the same problem and solve this by allowing platform / board-setup code to add entries to a lookup table and then use this table to look things up. This commit adds support for getting a mux controller on a non DT platform following this pattern. It is based on a simplified version of the pwm subsys lookup code, the dev_id and mux_name parts of a lookup table entry are mandatory in the mux-core implementation. Signed-off-by: Hans de Goede --- Changes in v2: -Fixup some kerneldoc comments, add kerneldoc comment to structs -Minor code-style tweaks --- drivers/mux/core.c | 93 +++++++++++++++++++++++++++++++++++++++++++- include/linux/mux/consumer.h | 19 +++++++++ 2 files changed, 111 insertions(+), 1 deletion(-) diff --git a/drivers/mux/core.c b/drivers/mux/core.c index 99d29f982c0e..e25bb7ab03ce 100644 --- a/drivers/mux/core.c +++ b/drivers/mux/core.c @@ -24,6 +24,9 @@ #include #include +static DEFINE_MUTEX(mux_lookup_lock); +static LIST_HEAD(mux_lookup_list); + /* * The idle-as-is "state" is not an actual state that may be selected, it * only implies that the state should not be changed. So, use that state @@ -408,6 +411,23 @@ int mux_control_deselect(struct mux_control *mux) } EXPORT_SYMBOL_GPL(mux_control_deselect); +static int parent_name_match(struct device *dev, const void *data) +{ + const char *parent_name = dev_name(dev->parent); + const char *name = data; + + return strcmp(parent_name, name) == 0; +} + +static struct mux_chip *mux_chip_get_by_name(const char *name) +{ + struct device *dev; + + dev = class_find_device(&mux_class, NULL, name, parent_name_match); + + return dev ? to_mux_chip(dev) : NULL; +} + static int of_dev_node_match(struct device *dev, const void *data) { return dev->of_node == data; @@ -480,6 +500,38 @@ static struct mux_control *of_mux_control_get(struct device *dev, } /** + * mux_add_table() - Register consumer to mux-controller mappings + * @table: array of mappings to register + * @num: number of mappings in table + */ +void mux_add_table(struct mux_lookup *table, size_t num) +{ + mutex_lock(&mux_lookup_lock); + + for (; num--; table++) + list_add_tail(&table->list, &mux_lookup_list); + + mutex_unlock(&mux_lookup_lock); +} +EXPORT_SYMBOL_GPL(mux_add_table); + +/** + * mux_remove_table() - Unregister consumer to mux-controller mappings + * @table: array of mappings to unregister + * @num: number of mappings in table + */ +void mux_remove_table(struct mux_lookup *table, size_t num) +{ + mutex_lock(&mux_lookup_lock); + + for (; num--; table++) + list_del(&table->list); + + mutex_unlock(&mux_lookup_lock); +} +EXPORT_SYMBOL_GPL(mux_remove_table); + +/** * mux_control_get() - Get the mux-control for a device. * @dev: The device that needs a mux-control. * @mux_name: The name identifying the mux-control. @@ -488,11 +540,50 @@ static struct mux_control *of_mux_control_get(struct device *dev, */ struct mux_control *mux_control_get(struct device *dev, const char *mux_name) { + struct mux_lookup *m, *chosen = NULL; + const char *dev_id = dev_name(dev); + struct mux_chip *mux_chip; + /* look up via DT first */ if (IS_ENABLED(CONFIG_OF) && dev->of_node) return of_mux_control_get(dev, mux_name); - return ERR_PTR(-ENODEV); + /* + * For non DT we look up the provider in the static table typically + * provided by board setup code. + * + * If a match is found, the provider mux chip is looked up by name + * and a mux-control is requested using the table provided index. + */ + mutex_lock(&mux_lookup_lock); + list_for_each_entry(m, &mux_lookup_list, list) { + if (WARN_ON(!m->dev_id || !m->mux_name || !m->provider)) + continue; + + if (!strcmp(m->dev_id, dev_id) && + !strcmp(m->mux_name, mux_name)) + { + chosen = m; + break; + } + } + mutex_unlock(&mux_lookup_lock); + + if (!chosen) + return ERR_PTR(-ENODEV); + + mux_chip = mux_chip_get_by_name(chosen->provider); + if (!mux_chip) + return ERR_PTR(-EPROBE_DEFER); + + if (chosen->index >= mux_chip->controllers) { + dev_err(dev, "Mux lookup table index out of bounds %u >= %u\n", + chosen->index, mux_chip->controllers); + put_device(&mux_chip->dev); + return ERR_PTR(-EINVAL); + } + + return &mux_chip->mux[chosen->index]; } EXPORT_SYMBOL_GPL(mux_control_get); diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h index ea96d4c82be7..62a8ec6171c9 100644 --- a/include/linux/mux/consumer.h +++ b/include/linux/mux/consumer.h @@ -18,6 +18,25 @@ struct device; struct mux_control; +/** + * struct mux_lookup - Mux consumer to mux-controller lookup table entry + * @list: List head, internal use only. + * @provider: dev_name() of the mux-chip's parent-dev. + * @index: mux-controller's index in the mux-chip's mux array + * @dev_id: dev_name() of the consumer to map to this controller + * @mux_name name the consumer passes to mux_control_get + */ +struct mux_lookup { + struct list_head list; + const char *provider; + unsigned int index; + const char *dev_id; + const char *mux_name; +}; + +void mux_add_table(struct mux_lookup *table, size_t num); +void mux_remove_table(struct mux_lookup *table, size_t num); + unsigned int mux_control_states(struct mux_control *mux); int __must_check mux_control_select(struct mux_control *mux, unsigned int state); -- 2.13.5