Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752564AbdIERZ6 (ORCPT ); Tue, 5 Sep 2017 13:25:58 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34591 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdIERZx (ORCPT ); Tue, 5 Sep 2017 13:25:53 -0400 X-Google-Smtp-Source: ADKCNb5SpyOgtomaxZw9uRcKZqq7pMNHJ4AVEzftn8I1OScxI6WD0b2tbIFzRsWFgAEL53J+JBjhow== From: Todd Kjos X-Google-Original-From: Todd Kjos To: gregkh@linuxfoundation.org, arve@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, maco@google.com, tkjos@google.com, xuyiping@hisilicon.com, gengyanping@hisilicon.com, shiwanglai@hisilicon.com Cc: Xu YiPing Subject: [PATCH] binder: fix an ret value override Date: Tue, 5 Sep 2017 10:25:38 -0700 Message-Id: <20170905172538.36758-1-tkjos@google.com> X-Mailer: git-send-email 2.14.1.581.gf28d330327-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 26 From: Xu YiPing commit 372e3147df70 ("binder: guarantee txn complete / errors delivered in-order") incorrectly defined a local ret value. This ret value will be invalid when out of the if block Signed-off-by: Xu YiPing Signed-off-by: Todd Kjos --- drivers/android/binder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 96cc28afa383..7ef9e7f05e17 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -2326,7 +2326,6 @@ static int binder_translate_handle(struct flat_binder_object *fp, (u64)node->ptr); binder_node_unlock(node); } else { - int ret; struct binder_ref_data dest_rdata; binder_node_unlock(node); -- 2.14.1.581.gf28d330327-goog