Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753138AbdIESur (ORCPT ); Tue, 5 Sep 2017 14:50:47 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbdIESup (ORCPT ); Tue, 5 Sep 2017 14:50:45 -0400 Date: Tue, 05 Sep 2017 11:50:44 -0700 (PDT) Message-Id: <20170905.115044.551456011251065741.davem@davemloft.net> To: thomas@m3y3r.de Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro From: David Miller In-Reply-To: <1504439110050-1907815276-6-diffsplit-thomas@m3y3r.de> References: <1504439110050-939061377-0-diffsplit-thomas@m3y3r.de> <1504439110050-1907815276-6-diffsplit-thomas@m3y3r.de> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Sep 2017 11:50:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 496 Lines: 14 From: Thomas Meyer Date: Sun, 03 Sep 2017 14:19:31 +0200 > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > yourself. > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e > 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) > /ARRAY_SIZE(\1)/g' and manual check/verification. > > Signed-off-by: Thomas Meyer This should be submitted to the Intel ethernet driver maintainers. Thank you.