Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752844AbdIET0s (ORCPT ); Tue, 5 Sep 2017 15:26:48 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35973 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbdIET0r (ORCPT ); Tue, 5 Sep 2017 15:26:47 -0400 X-Google-Smtp-Source: ADKCNb4De//ywByr4nN34xNczeOAX40deYGrQYzopsCyuwrfXB5sefcbLI6ztCb5CBDIaT9s0VlVW0mKMsXDO2X1gq8= MIME-Version: 1.0 In-Reply-To: <20170905182326.15681-1-mwilck@suse.com> References: <20170905182326.15681-1-mwilck@suse.com> From: Arnd Bergmann Date: Tue, 5 Sep 2017 21:26:45 +0200 X-Google-Sender-Auth: GZF2vKNiYiebrW8M6jfw-dGxRgk Message-ID: Subject: Re: [PATCH] string.h: un-fortify memcpy_and_pad To: Martin Wilck Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg , Johannes Thumshirn , Hannes Reinecke , linux-nvme@lists.infradead.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 20 On Tue, Sep 5, 2017 at 8:23 PM, Martin Wilck wrote: > The way I'd implemented the new helper memcpy_and_pad with > __FORTIFY_INLINE caused compiler warnings for certain kernel > configurations. > > This helper is only used in a single place at this time, and thus > doesn't benefit much from fortification. So simplify the code > by dropping fortification support for now. > > Fixes: 3c5fa8cd18f8 "string.h: add memcpy_and_pad()" > Signed-off-by: Martin Wilck Looks good to me, Acked-by: Arnd Bergmann I've added this to my randconfig testing tree, if you don't hear anything from me by tomorrow, you can assume that it caused no other failures. Arnd