Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbdIEVWN (ORCPT ); Tue, 5 Sep 2017 17:22:13 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:39290 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbdIEVWH (ORCPT ); Tue, 5 Sep 2017 17:22:07 -0400 Date: Tue, 05 Sep 2017 14:22:05 -0700 (PDT) Message-Id: <20170905.142205.14687531780483930.davem@davemloft.net> To: joe@perches.com Cc: thomas@m3y3r.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro From: David Miller In-Reply-To: <1504641678.28899.12.camel@perches.com> References: <20170905.115044.551456011251065741.davem@davemloft.net> <20170905194419.pdwrkqdad6tbq7hs@olymp> <1504641678.28899.12.camel@perches.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Sep 2017 14:22:07 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1679 Lines: 43 From: Joe Perches Date: Tue, 05 Sep 2017 13:01:18 -0700 > On Tue, 2017-09-05 at 21:45 +0200, Thomas Meyer wrote: >> On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote: >> > From: Thomas Meyer >> > Date: Sun, 03 Sep 2017 14:19:31 +0200 >> > >> > > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it >> > > yourself. >> > > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e >> > > 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) >> > > /ARRAY_SIZE(\1)/g' and manual check/verification. >> > > >> > > Signed-off-by: Thomas Meyer >> > >> > This should be submitted to the Intel ethernet driver maintainers. >> >> Hi, >> >> my script checks the output of get_maintainer scripts and only sends to "open >> list" entries. >> >> The intel-wired-lan@lists.osuosl.org is moderated, so that's why the patch >> wasn't send there. >> >> Strangely the lists for nouveau@lists.freedesktop.org and >> intel-gvt-dev@lists.freedesktop.org appears as open lists in the MAINTAINERS >> file but seems to be also moderated lists... At least I got some reply that my >> message awaits approval. Maybe an update to the MAINTAINERS file is missing >> here? >> >> I may drop above check in my script and send to all mailing lists that >> get_maintainer.pl will return. > > There's a difference between moderated and subscriber-only > entries in MAINTAINERS. > > get_maintainers will by default list moderated lists and > not show subscriber-only lists unless using the -s switch. Furthermore, nothing prevented you from CC:'ing the maintainer, Jeff Kirscher.