Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753653AbdIEVuE convert rfc822-to-8bit (ORCPT ); Tue, 5 Sep 2017 17:50:04 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:39910 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753573AbdIEVuB (ORCPT ); Tue, 5 Sep 2017 17:50:01 -0400 Date: Tue, 05 Sep 2017 14:50:00 -0700 (PDT) Message-Id: <20170905.145000.2066751800287170482.davem@davemloft.net> To: Haakon.Bugge@oracle.com Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, knut.omang@oracle.com, wei.lin.guay@oracle.com Subject: Re: [PATCH net] rds: Fix non-atomic operation on shared flag variable From: David Miller In-Reply-To: <20170905154201.30198-1-Haakon.Bugge@oracle.com> References: <20170905154201.30198-1-Haakon.Bugge@oracle.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Sep 2017 14:50:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 473 Lines: 12 From: H?kon Bugge Date: Tue, 5 Sep 2017 17:42:01 +0200 > The bits in m_flags in struct rds_message are used for a plurality of > reasons, and from different contexts. To avoid any missing updates to > m_flags, use the atomic set_bit() instead of the non-atomic equivalent. > > Signed-off-by: H?kon Bugge > Reviewed-by: Knut Omang > Reviewed-by: Wei Lin Guay Applied.