Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbdIFIDS (ORCPT ); Wed, 6 Sep 2017 04:03:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51478 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbdIFIDM (ORCPT ); Wed, 6 Sep 2017 04:03:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C68955D5EA Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=bhe@redhat.com Date: Wed, 6 Sep 2017 16:03:04 +0800 From: Baoquan He To: Dou Liyang Cc: x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, rjw@rjwysocki.net, bp@alien8.de, indou.takao@jp.fujitsu.com, izumi.taku@jp.fujitsu.com Subject: Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup Message-ID: <20170906080304.GJ30906@x1> References: <1503890438-27840-1-git-send-email-douly.fnst@cn.fujitsu.com> <1503890438-27840-7-git-send-email-douly.fnst@cn.fujitsu.com> <20170906042514.GF30906@x1> <20170906052614.GG30906@x1> <96aae229-04d4-fc31-9646-3ca7c029365a@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96aae229-04d4-fc31-9646-3ca7c029365a@cn.fujitsu.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 06 Sep 2017 08:03:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1767 Lines: 73 On 09/06/17 at 01:41pm, Dou Liyang wrote: > Hi Baoquan, > > At 09/06/2017 01:26 PM, Baoquan He wrote: > [...] > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index 4f63afc..9f8479c 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -1260,8 +1260,10 @@ static void __init smp_get_logical_apicid(void) > } > > /* > - * Prepare for SMP bootup. The MP table or ACPI has been read > - * earlier. Just do some sanity checking here and enable APIC mode. > + * Prepare for SMP bootup. > + * > + * @max_cpus: configured maximum number of CPUs > + * It don't be used, but other arch also have this hook, so keep it. Yeah, makes sense. Above words can be reconsidered. > */ > void __init native_smp_prepare_cpus(unsigned int max_cpus) > { > > Thanks, > dou. > > > > > > static noinline void __init kernel_init_freeable(void) > > > { > > > ... > > > smp_prepare_cpus(setup_max_cpus); > > > ... > > > } > > > > > > > > > > > apic_intr_mode_init(); > > > > > > > > - switch (smp_sanity_check(max_cpus)) { > > > > - case SMP_NO_CONFIG: > > > > - disable_smp(); > > > > - return; > > > > - case SMP_NO_APIC: > > > > + smp_sanity_check(); > > > > + > > > > + switch (apic_intr_mode) { > > > > + case APIC_PIC: > > > > + case APIC_VIRTUAL_WIRE_NO_CONFIG: > > > > disable_smp(); > > > > return; > > > > - case SMP_FORCE_UP: > > > > + case APIC_SYMMETRIC_IO_NO_ROUTING: > > > > disable_smp(); > > > > /* Setup local timer */ > > > > x86_init.timers.setup_percpu_clockev(); > > > > return; > > > > - case SMP_OK: > > > > + case APIC_VIRTUAL_WIRE: > > > > + case APIC_SYMMETRIC_IO: > > > > break; > > > > } > > > > > > > > -- > > > > 2.5.5 > > > > > > > > > > > > > > > > > > > >