Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752476AbdIFJEy (ORCPT ); Wed, 6 Sep 2017 05:04:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:54239 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752361AbdIFJEw (ORCPT ); Wed, 6 Sep 2017 05:04:52 -0400 Date: Wed, 6 Sep 2017 11:04:50 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@wotan.suse.de To: =?ISO-8859-15?Q?Maxime_Belleng=E9?= cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: asus: Add support for Fn keys on Asus ROG G752 In-Reply-To: <20170820125814.21641-1-maxime.bellenge@gmail.com> Message-ID: References: <20170820125814.21641-1-maxime.bellenge@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 455 Lines: 20 On Sun, 20 Aug 2017, Maxime Belleng? wrote: > This patch adds support for Fn keys on Asus ROG G752 laptop. > The report descriptor is broken so I fixed it. > > Tested on an Asus G752VT. > > Signed-off-by: Maxime Belleng? Looks good to me, but the patch is whitespace damaged (it adds only spaces, no tabs). Could you please fix that up and resend (with Benjamin's Reviewed-by added)? Thanks, -- Jiri Kosina SUSE Labs