Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752341AbdIFJIY (ORCPT ); Wed, 6 Sep 2017 05:08:24 -0400 Received: from www17.your-server.de ([213.133.104.17]:57047 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751907AbdIFJIW (ORCPT ); Wed, 6 Sep 2017 05:08:22 -0400 Date: Wed, 6 Sep 2017 11:08:17 +0200 From: Thomas Meyer To: David Miller Cc: joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro Message-ID: <20170906090817.f7qir5okeeajfcsc@olymp> References: <20170905.115044.551456011251065741.davem@davemloft.net> <20170905194419.pdwrkqdad6tbq7hs@olymp> <1504641678.28899.12.camel@perches.com> <20170905.142205.14687531780483930.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170905.142205.14687531780483930.davem@davemloft.net> User-Agent: NeoMutt/20170113 (1.7.2) X-Authenticated-Sender: thomas@m3y3r.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2066 Lines: 55 On Tue, Sep 05, 2017 at 02:22:05PM -0700, David Miller wrote: > From: Joe Perches > Date: Tue, 05 Sep 2017 13:01:18 -0700 > > > On Tue, 2017-09-05 at 21:45 +0200, Thomas Meyer wrote: > >> On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote: > >> > From: Thomas Meyer > >> > Date: Sun, 03 Sep 2017 14:19:31 +0200 > >> > > >> > > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > >> > > yourself. > >> > > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e > >> > > 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) > >> > > /ARRAY_SIZE(\1)/g' and manual check/verification. > >> > > > >> > > Signed-off-by: Thomas Meyer > >> > > >> > This should be submitted to the Intel ethernet driver maintainers. > >> > >> Hi, > >> > >> my script checks the output of get_maintainer scripts and only sends to "open > >> list" entries. > >> > >> The intel-wired-lan@lists.osuosl.org is moderated, so that's why the patch > >> wasn't send there. > >> > >> Strangely the lists for nouveau@lists.freedesktop.org and > >> intel-gvt-dev@lists.freedesktop.org appears as open lists in the MAINTAINERS > >> file but seems to be also moderated lists... At least I got some reply that my > >> message awaits approval. Maybe an update to the MAINTAINERS file is missing > >> here? > >> > >> I may drop above check in my script and send to all mailing lists that > >> get_maintainer.pl will return. > > > > There's a difference between moderated and subscriber-only > > entries in MAINTAINERS. > > > > get_maintainers will by default list moderated lists and > > not show subscriber-only lists unless using the -s switch. > > Furthermore, nothing prevented you from CC:'ing the maintainer, > Jeff Kirscher. Hi, That's the other condition in my script. I only send to the role "maintainer" from the output of get_maintainer.pl. But Mr Jeff Kirscher is only listed as supporter... Anyway I did bounce the email to him. with kind regards thomas