Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533AbdIFJKq (ORCPT ); Wed, 6 Sep 2017 05:10:46 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5548 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbdIFJKj (ORCPT ); Wed, 6 Sep 2017 05:10:39 -0400 Subject: Re: a competition when some threads acquire futex To: Thomas Gleixner CC: , , , , References: <3e497508-876f-6474-3f3d-acab06a63b55@huawei.com> <555186f2-8240-f7d0-e1b0-9ad1a67ff34c@huawei.com> From: "chengjian (D)" Message-ID: Date: Wed, 6 Sep 2017 17:09:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.219.85] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.59AFBB5C.0119,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 20a3e6054a85edda9bbf59ff5be768f5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 569 Lines: 21 On 2017/9/6 16:36, Thomas Gleixner write: > Ok. Still that patch has issues. > > 1) It's white space damaged. Please use TAB not spaces for > indentation. checkpatch.pl would have told you. > > 2) Why are you using _cond_resched() instead of plain cond_resched(). > > cond_resched() is what you want to use. Hi Thomas. I am very sorry about the issues of my patch. I am a kernel newbie and i set expandtab in my .vimrc file which means tab characters are converted to spaces. I have fixed it and will check my patch first next time. Thanks. Cheng Jian