Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753506AbdIFLOn (ORCPT ); Wed, 6 Sep 2017 07:14:43 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:43896 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116AbdIFLOl (ORCPT ); Wed, 6 Sep 2017 07:14:41 -0400 Date: Wed, 6 Sep 2017 13:14:35 +0200 From: Ralf Baechle To: Rocco Folino Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Antony Pavlov , Alban Bedel , John Crispin Subject: Re: [PATCH] MIPS: ath79: support devicetree selection Message-ID: <20170906111435.GA1856@linux-mips.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 971 Lines: 30 On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote: > Allow to choose devicetrees from Kconfig. > > Signed-off-by: Rocco Folino > --- > arch/mips/ath79/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++ > arch/mips/boot/dts/qca/Makefile | 10 +++++----- > 2 files changed, 49 insertions(+), 5 deletions(-) > > diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig > index dfc60209dc63..b43d116187af 100644 > --- a/arch/mips/ath79/Kconfig > +++ b/arch/mips/ath79/Kconfig > @@ -1,5 +1,49 @@ > if ATH79 > > +menu "Atheros AR71XX/AR724X/AR913X devicetree selection" > + > +config DTB_ATH_DPT_MODULE > + bool "DPTechnics DPT-Module" > + select SOC_933X There is no symbol SOC_933X. Did you mean SOC_AR933X? Anyway, your patch does more than the changelog ("Allow to choose devicetrees from Kconfig") says, so please either fix the changelog or split that into multiple patches with proper changelogs. Ralf